From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66863: [PATCH] Add two docstrings in cl-macs.el Date: Wed, 01 Nov 2023 08:17:36 -0400 Message-ID: References: <87bkcexvoy.fsf@jeremybryant.net> <8734xqxstn.fsf@jeremybryant.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11850"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66863@debbugs.gnu.org To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 01 13:18:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qyABF-0002rZ-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Nov 2023 13:18:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qyAB4-0000Mh-S5; Wed, 01 Nov 2023 08:18:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyAB2-0000M1-0A for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2023 08:18:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qyAB1-0000LT-Nk for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2023 08:18:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qyABa-0006Am-12 for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2023 08:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Nov 2023 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169884110723667 (code B ref -1); Wed, 01 Nov 2023 12:19:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Nov 2023 12:18:27 +0000 Original-Received: from localhost ([127.0.0.1]:50105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyAB1-00069e-41 for submit@debbugs.gnu.org; Wed, 01 Nov 2023 08:18:27 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:42478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyAAx-00069N-27 for submit@debbugs.gnu.org; Wed, 01 Nov 2023 08:18:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyAAI-0007m4-CO for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2023 08:17:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyAAG-0000E6-Bd for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2023 08:17:42 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C177644145F; Wed, 1 Nov 2023 08:17:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698841057; bh=X8wFfqlV8MxIDVxtkpYGAfz3N00z6KPTgi/Qmm7D2LY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MNLPzzdNsQet8HM+65YcyODMBlZNKh9cdafmThI134pM01S6xUPT/9iJVa5z3jQ9f Qo8X4lOXZvH6ImJFP1EgYVKRFzpVh/RuaOteH+eJRZlJVXGsbbcW2jEzD1mhUnML8G xdaeYP/NITUS6uFkN+r8fltaWGR03oCMwTaubOOHPnGubimhHM5XLxaF3xvFG9crVz +CztjjQi32IXRmWxJfLpG59TDQOvHqGtVQ3WUFZ86rd7793KlgRMUlPcLrZ8iID97a HTO/OFF7OKu0lb8DuwwklPuwvYP3wUwAkyrZ7mFTn6CAcT13t6tFWSas3Cduc5Hy2I JHhbF+8wfJprQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AEC1744143A; Wed, 1 Nov 2023 08:17:37 -0400 (EDT) Original-Received: from pastel (unknown [45.72.195.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8B83D1201E3; Wed, 1 Nov 2023 08:17:37 -0400 (EDT) In-Reply-To: <8734xqxstn.fsf@jeremybryant.net> (Jeremy Bryant's message of "Tue, 31 Oct 2023 23:40:04 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273596 Archived-At: > From 16298965905b1859aa8a342b98803f4abd6da3f0 Mon Sep 17 00:00:00 2001 > From: Jeremy Bryant > Date: Tue, 31 Oct 2023 23:37:10 +0000 > Subject: [PATCH] Add two docstrings in cl-macs.el Thanks, pushed. > (defun cl--simple-exprs-p (xs) > + "Map `cl--simple-expr-p' to each element of list XS." This doesn't say how the results of `cl--simple-expr-p` are combined, it might even suggest they're returned as a list. I think I would have said something like "Like `cl--simple-expr-p' but for a list of expressions." > (defun cl--const-expr-p (x) > + "Check if X is constant (i.e., no side effects or dependencies). > + > +See `macroexp-const-p' for similar functionality without cl-lib dependency." "Similar" fails to describe the difference :-( [ Note, I can't blame you: I know the difference but I couldn't come up with a useful description of it, that is, one that is easier to understand than the code itself. FWIW I believe the difference is a latent bug, which is partly why I'd like to delete the function :-) ] Stefan