PCL-CVS: `A' opens wrong ChangeLog file

PCL-CVS: `A' opens wrong ChangeLog file

[Reiner Steib]

Hi,

in PCL-CVS `A' (cvs-mode-add-change-log-entry-other-window) picks the
wrong ChangeLog file when point is the region between point-min and
"In directory .:" [1].  Instead of `./ChangeLog', it visits
`../ChangeLog'.

To reproduce:

M-x cvs-update RET /path/to/working-copy RET

M-: default-directory RET                         (in buffer *cvs*)
==> "/home/ste/work/emacs/lisp/"

A                      (cvs-mode-add-change-log-entry-other-window)
M-: (buffer-file-name) RET
==> "/home/ste/work/emacs/ChangeLog"                     <== Wrong!

Expected behavior:
--> "/home/ste/work/emacs/lisp/ChangeLog"
    ... as the doc string says:

,----[ <f1> f cvs-mode-add-change-log-entry-other-window RET ]
| cvs-mode-add-change-log-entry-other-window is an interactive
| compiled Lisp function in `pcvs.elc'.
| (cvs-mode-add-change-log-entry-other-window)
| 
| Add a ChangeLog entry in the ChangeLog of the current directory.
|                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
`----

Emacs version: Emacs 22 branch from CVS (last updated and build on
2007-06-28).  See below for more: [2].

Bye, Reiner.

[1]
--8<---------------cut here---------------start------------->8---
Repository : /home/ste/cvs
Module     : emacs/lisp
Working dir: ~/work/emacs/lisp/



In directory .:
--8<---------------cut here---------------end--------------->8---

[2]
In GNU Emacs 22.1.50.4 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
 of 2007-06-28 on viandante
Windowing system distributor `The X.Org Foundation', version 11.0.70199902
configured using `configure  '--prefix=/import/xtra/emacs/RC' '--with-gtk' '--exec-prefix=/import/xtra/emacs/RC-i686''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Change Log

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<help-echo> C-x 5 b M <backspace> <return> <help-echo> 
<help-echo> <help-echo> <switch-frame> M-: d e f a 
l t <backspace> <backspace> u l t - d i r e c t o r 
y <return> M-x c v s - u p d <tab> <return> <return> 
M-: <up> <return> A M-: b u f f e r - f i l e - n a 
m e C-a ( C-e ) <return> M-: <up> <up> <return> M-x 
r e p o <tab> r <tab> <return>

Recent messages:
Loading add-log...done
Loading vc-cvs...done
(New file)
"/home/ste/work/emacs/ChangeLog"
"/home/ste/work/emacs/"
Making completion list...
Loading help-mode...done
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: PCL-CVS: `A' opens wrong ChangeLog file

[Stefan Monnier]

> in PCL-CVS `A' (cvs-mode-add-change-log-entry-other-window) picks the
> wrong ChangeLog file when point is the region between point-min and
> "In directory .:" [1].  Instead of `./ChangeLog', it visits
> `../ChangeLog'.

Thanks, should be fixed now,


        Stefan

Re: PCL-CVS: `A' opens wrong ChangeLog file

[Reiner Steib]

On Fri, Jul 20 2007, Stefan Monnier wrote:

>> in PCL-CVS `A' (cvs-mode-add-change-log-entry-other-window) picks the
>> wrong ChangeLog file when point is the region between point-min and
>> "In directory .:" [1].  Instead of `./ChangeLog', it visits
>> `../ChangeLog'.
>
> Thanks, should be fixed now,

Thanks.  AFAICS, you only installed it in the trunk.  Shouldn't the
fix be installed in Emacs 22 as well?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: PCL-CVS: `A' opens wrong ChangeLog file

[Stefan Monnier]

>>> in PCL-CVS `A' (cvs-mode-add-change-log-entry-other-window) picks the
>>> wrong ChangeLog file when point is the region between point-min and
>>> "In directory .:" [1].  Instead of `./ChangeLog', it visits
>>> `../ChangeLog'.
>> 
>> Thanks, should be fixed now,

> Thanks.  AFAICS, you only installed it in the trunk.  Shouldn't the
> fix be installed in Emacs 22 as well?

Done,


        Stefan