From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: dired cannot access file names with a quote Date: Sat, 23 Feb 2008 19:26:15 -0500 Message-ID: References: <87r6f3ux2z.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203812794 11849 80.91.229.12 (24 Feb 2008 00:26:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Feb 2008 00:26:34 +0000 (UTC) Cc: Francesco =?iso-8859-1?Q?Potort=1FFFFFFF?= , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 24 01:26:59 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JT4hm-0001oW-T9 for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2008 01:26:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JT4hH-0000Pc-F5 for ged-emacs-devel@m.gmane.org; Sat, 23 Feb 2008 19:26:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JT4hE-0000PX-0A for emacs-devel@gnu.org; Sat, 23 Feb 2008 19:26:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JT4hB-0000PL-Gp for emacs-devel@gnu.org; Sat, 23 Feb 2008 19:26:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JT4hB-0000PH-Bu for emacs-devel@gnu.org; Sat, 23 Feb 2008 19:26:21 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JT4h7-00059U-Gg; Sat, 23 Feb 2008 19:26:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CACtIwEdMCpz5Wmdsb2JhbACQUQEgmnuBAA X-IronPort-AV: E=Sophos;i="4.25,396,1199682000"; d="scan'208";a="14890580" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 23 Feb 2008 19:26:15 -0500 Original-Received: from pastel.home ([76.10.156.249]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id ECY84715; Sat, 23 Feb 2008 19:26:15 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 5E59C8A41; Sat, 23 Feb 2008 19:26:15 -0500 (EST) In-Reply-To: <87r6f3ux2z.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 23 Feb 2008 17:28:20 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90186 Archived-At: > I think the fix is to quote ' as well in shell-quote-wildcard-pattern. > Could someone on this list double-check? I haven't had time to check if that makes sense, but if it makes sense, then " should probably be added as well. Stefan > *** emacs/lisp/files.el.~1.896.2.37.~ 2008-01-29 13:34:43.000000000 -0500 > --- emacs/lisp/files.el 2008-02-23 17:25:50.000000000 -0500 > *************** > *** 4774,4780 **** > PATTERN is assumed to represent a file-name wildcard suitable for the > underlying filesystem. For Unix and GNU/Linux, the characters from the > ! set [ \\t\\n;<>&|()#$] are quoted with a backslash; for DOS/Windows, all > the parts of the pattern which don't include wildcard characters are > quoted with double quotes. > Existing quote characters in PATTERN are left alone, so you can pass > --- 4774,4780 ---- > PATTERN is assumed to represent a file-name wildcard suitable for the > underlying filesystem. For Unix and GNU/Linux, the characters from the > ! set [ \\t\\n;<>&|()#$'] are quoted with a backslash; for DOS/Windows, all > the parts of the pattern which don't include wildcard characters are > quoted with double quotes. > Existing quote characters in PATTERN are left alone, so you can pass > *************** > *** 4806,4812 **** > (concat result (substring pattern beg) "\"")))) > (t > (let ((beg 0)) > ! (while (string-match "[ \t\n;<>&|()#$]" pattern beg) > (setq pattern > (concat (substring pattern 0 (match-beginning 0)) > "\\" > --- 4806,4812 ---- > (concat result (substring pattern beg) "\"")))) > (t > (let ((beg 0)) > ! (while (string-match "[ \t\n;<>&|()#$']" pattern beg) > (setq pattern > (concat (substring pattern 0 (match-beginning 0)) > "\\"