all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: lgfang <fanglungang@163.com>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: comment-kill can't deal with following situation
Date: Sun, 02 Mar 2008 16:42:17 -0500	[thread overview]
Message-ID: <jwvejasvmh9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86hcfps0c2.fsf@163.com> (lgfang's message of "Sun, 02 Mar 2008 21:49:01 +0800")

>>> comment-kill is defined in newcomment.el.  It is supposed to
>>> kill comments (refer to its document).  But it can't deal with
>>> the cases in which there are more than one comment in a line.
>>> An example is:

Stefan> If you do not provide a prefix arg, comment-kill should
Stefan> only kill 1 comment.  Indeed when providing a prefix arg,

> The document says:

>     Kill the comment on this line, if any. With prefix ARG, kill
>     comments on that many lines starting with this one.

> So, take following C code for example:
> int j; /* comment 1 */ int k; /* comment 2*/

> I think comment-kill should kill both comment 1 and comment 2 even
> without prefix ARG.

Here I disagree.  I find it more useful to only kill one comment at
a time (you can always choose to run the command 2 times, but you cannot
run it 1/2 a time).  Also the docstring says "kill *the comment* on this
line", which admittedly is ambiguous when there are more than
1 comments, but indicates a clear intention to only kill 1 comment.

Stefan> But in the presence of multi-line comments, the behavior
Stefan> doesn't match the docstring either.

> Even if all comments reside in one line and call comment-kill either
> with/without prefix arg, the behavior is in-correct so long as there
> are more than one comments.

We should not make a design decision based on the behavior in one
particular kind of circumstances (only single-line comments), since
that's how we got into this mess in the first place.

So please reply to my previous request:

   I don't know of anybody who uses the prefix arg of comment-kill, so
   if you could explain how you use it, it might help decide what the
   behavior should be.


-- Stefan




  parent reply	other threads:[~2008-03-02 21:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <198A33EB1E9E344EBC566802C7761D6B4ACE3C@CNSHGSMBS04.ad4.ad.alcatel.com>
2008-02-29 11:02 ` comment-kill can't deal with following situation lgfang
2008-03-02  5:14   ` Stefan Monnier
2008-03-02 13:49     ` lgfang
2008-03-02 16:12       ` Andreas Röhler
2008-03-02 21:42       ` Stefan Monnier [this message]
2008-03-03 12:04         ` lgfang
2008-03-03 14:10           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvejasvmh9.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=fanglungang@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.