From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar and multi-tty Date: Fri, 10 Oct 2008 13:18:31 -0400 Message-ID: References: <873aj56v2p.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1223659144 7191 80.91.229.12 (10 Oct 2008 17:19:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Oct 2008 17:19:04 +0000 (UTC) Cc: Chong Yidong , dann@ics.uci.edu, 1133@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 10 19:19:59 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KoLeU-0004RD-1H for ged-emacs-devel@m.gmane.org; Fri, 10 Oct 2008 19:19:46 +0200 Original-Received: from localhost ([127.0.0.1]:44078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KoLdP-0007ES-UL for ged-emacs-devel@m.gmane.org; Fri, 10 Oct 2008 13:18:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KoLdK-0007D1-TY for emacs-devel@gnu.org; Fri, 10 Oct 2008 13:18:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KoLdJ-0007AO-Aa for emacs-devel@gnu.org; Fri, 10 Oct 2008 13:18:34 -0400 Original-Received: from [199.232.76.173] (port=33650 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KoLdJ-0007AE-6I for emacs-devel@gnu.org; Fri, 10 Oct 2008 13:18:33 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:58651) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KoLdI-0007ai-8G; Fri, 10 Oct 2008 13:18:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGMr70jO+IH3/2dsb2JhbACBcrtIgWyBCQ X-IronPort-AV: E=Sophos;i="4.33,390,1220241600"; d="scan'208";a="28270859" Original-Received: from 206-248-129-247.dsl.teksavvy.com (HELO pastel.home) ([206.248.129.247]) by ironport2-out.teksavvy.com with ESMTP; 10 Oct 2008 13:18:31 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 10ABF7F84; Fri, 10 Oct 2008 13:18:31 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Fri, 10 Oct 2008 09:51:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104462 Archived-At: >> Bug 1133 notes a problem with tool-bars and multi-tty. Basically, >> tool-bar-map is not set up if the first frame is on a tty; it is only >> initialized when the first graphical frame is created. This causes >> problems for major modes that define their own tool-bar maps. >> >> I think the solution is to define a normal hook, tool-bar-setup-hook, to >> be run after the tool-bar is set up successfully for the first time. > This sounds like a very complicated solution. Why can't we set up > tool-bar-map unconditionally? Perhaps changes that make that possible > are much smaller and cleaner than what you suggest here? My thoughts exactly... Why? Stefan