From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Date: Wed, 04 Feb 2009 14:46:49 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233777044 28563 80.91.229.12 (4 Feb 2009 19:50:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2009 19:50:44 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, 2137@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 20:51:58 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUnmv-0008S1-J4 for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2009 20:51:57 +0100 Original-Received: from localhost ([127.0.0.1]:38374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUnlc-0005wE-LF for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2009 14:50:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUni8-0003v7-5L for emacs-devel@gnu.org; Wed, 04 Feb 2009 14:47:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUni6-0003uv-NX for emacs-devel@gnu.org; Wed, 04 Feb 2009 14:46:58 -0500 Original-Received: from [199.232.76.173] (port=44700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUni6-0003us-J8 for emacs-devel@gnu.org; Wed, 04 Feb 2009 14:46:58 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53280) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUni3-0007mA-Pw; Wed, 04 Feb 2009 14:46:55 -0500 Original-Received: from alfajor.home (vpn-132-204-232-41.acd.umontreal.ca [132.204.232.41]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n14JlUBB005812; Wed, 4 Feb 2009 14:47:30 -0500 Original-Received: by alfajor.home (Postfix, from userid 20848) id 52C1FA22D8; Wed, 4 Feb 2009 14:46:49 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Wed, 04 Feb 2009 06:16:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3204=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108749 Archived-At: >> The bug is that is uses buffer-size to determine the size of the file, >> without taking into account the fact that >> write-region-annotate-functions can add lot of stuff to the file that's >> not in the buffer's text. > How can buffer-size take that into account? It can't. Luckily we don't have to use buffer-size for that. > The correct full size of what's written to the disk file is never > seen, since write-region does its job piecemeal, and the annotations > are applied separately to each piece by a_write. Indeed. > Am I missing something? We do have all the annotations in a single place, so we can compute the final total size before we start writing. >> The simplest fix is to simply always output the message rather than only >> for files larger than 50KB. > That may be the only (non-kludgey) solution. Yes, I find it to be the best solution. I see no benefit in avoiding the message for smaller files. Stefan