From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, rms@gnu.org, 2137@emacsbugs.donarmstrong.com
Subject: Re: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message
Date: Wed, 04 Feb 2009 14:46:49 -0500 [thread overview]
Message-ID: <jwveiyeng10.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <u7i46vnun.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Feb 2009 06:16:00 +0200")
>> The bug is that is uses buffer-size to determine the size of the file,
>> without taking into account the fact that
>> write-region-annotate-functions can add lot of stuff to the file that's
>> not in the buffer's text.
> How can buffer-size take that into account?
It can't. Luckily we don't have to use buffer-size for that.
> The correct full size of what's written to the disk file is never
> seen, since write-region does its job piecemeal, and the annotations
> are applied separately to each piece by a_write.
Indeed.
> Am I missing something?
We do have all the annotations in a single place, so we can compute the
final total size before we start writing.
>> The simplest fix is to simply always output the message rather than only
>> for files larger than 50KB.
> That may be the only (non-kludgey) solution.
Yes, I find it to be the best solution. I see no benefit in avoiding
the message for smaller files.
Stefan
next prev parent reply other threads:[~2009-02-04 19:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ud4dutuhg.fsf@gnu.org>
2009-01-31 19:13 ` bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Eli Zaretskii
2009-02-01 22:48 ` Richard M Stallman
2009-02-02 1:35 ` Stefan Monnier
2009-02-02 21:05 ` Eli Zaretskii
2009-02-02 21:05 ` Eli Zaretskii
2009-02-03 4:12 ` Glenn Morris
2009-02-03 19:31 ` Eli Zaretskii
2009-02-03 21:26 ` Stefan Monnier
2009-02-04 4:23 ` Eli Zaretskii
2009-02-04 18:29 ` Eli Zaretskii
2009-02-04 18:27 ` Richard M Stallman
2009-02-04 19:49 ` Stefan Monnier
2009-02-04 20:14 ` Eli Zaretskii
2009-02-04 23:21 ` Stefan Monnier
2009-02-05 16:39 ` Richard M Stallman
2009-02-04 20:12 ` Eli Zaretskii
2009-02-03 21:29 ` Stefan Monnier
2009-02-03 21:29 ` Stefan Monnier
2009-02-04 4:16 ` Eli Zaretskii
2009-02-04 19:46 ` Stefan Monnier
2009-02-04 19:46 ` Stefan Monnier [this message]
2009-02-04 4:16 ` Eli Zaretskii
2009-02-03 9:59 ` Richard M Stallman
2009-02-03 9:59 ` Richard M Stallman
2009-02-03 19:39 ` Eli Zaretskii
2009-02-02 1:35 ` Stefan Monnier
2009-02-07 10:35 ` bug#2137: marked as done (23.0.60; Saving Rmail buffer does not show the "Saving file ..." message) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwveiyeng10.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=2137@emacsbugs.donarmstrong.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.