* bug#2585: 23.0.90; read-file-name with dialog
@ 2009-03-06 18:41 MJ
2009-03-07 7:50 ` Jason Rumney
0 siblings, 1 reply; 4+ messages in thread
From: MJ @ 2009-03-06 18:41 UTC (permalink / raw)
To: emacs-pretest-bug
When read-file-name is called and uses windows dialog to read a file
name, the 'dir' parameter has to be ended with '/'. It it does not,
the last part of the path name is used as the filename while the
default directory is the stripped 'dir' without last part. This does
not happen in Emacs 22.
In minibuffer, there is comment that says:
;; If DIR contains a file name, split it.
I'm not sure if that is the right thing to do. At least, it breaks the
compatibility with previous Emacs version.
Is this an intended change?
Thanks.
--
In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
of 2009-02-22 on T42
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -I../../GnuWin32/include'
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#2585: 23.0.90; read-file-name with dialog
2009-03-06 18:41 MJ
@ 2009-03-07 7:50 ` Jason Rumney
0 siblings, 0 replies; 4+ messages in thread
From: Jason Rumney @ 2009-03-07 7:50 UTC (permalink / raw)
To: MJ, 2585; +Cc: emacs-pretest-bug
Whoever did the conversion of read-file-name from C to lisp probably
knows what was meant by this, by my naive impression is that the
following logic is a mistake:
;; If DIR contains a file name, split it.
(let ((file (file-name-nondirectory dir)))
(when (and default-filename (not (zerop (length file))))
(setq default-filename file)
(setq dir (file-name-directory dir)))
The third line makes more sense to me as:
(when (and (not default-filename) (not (zerop (length file))))
ie. if default-filename is specified, then the splitting should NOT be done.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#2585: 23.0.90; read-file-name with dialog
@ 2009-03-08 20:05 Chong Yidong
2009-03-08 20:24 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Chong Yidong @ 2009-03-08 20:05 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 2585, MJ
> Whoever did the conversion of read-file-name from C to lisp probably
> knows what was meant by this, by my naive impression is that the
> following logic is a mistake:
>
> ;; If DIR contains a file name, split it.
> (let ((file (file-name-nondirectory dir)))
> (when (and default-filename (not (zerop (length file))))
> (setq default-filename file)
> (setq dir (file-name-directory dir)))
>
> The third line makes more sense to me as:
>
> (when (and (not default-filename) (not (zerop (length file))))
>
> ie. if default-filename is specified, then the splitting should NOT be
> done.
That seems right to me. Stefan, you were the one who rewrote
read-file-name; could you verify this?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#2585: 23.0.90; read-file-name with dialog
2009-03-08 20:05 bug#2585: 23.0.90; read-file-name with dialog Chong Yidong
@ 2009-03-08 20:24 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2009-03-08 20:24 UTC (permalink / raw)
To: Chong Yidong; +Cc: 2585, MJ
>> Whoever did the conversion of read-file-name from C to lisp probably
>> knows what was meant by this, by my naive impression is that the
>> following logic is a mistake:
>>
>> ;; If DIR contains a file name, split it.
>> (let ((file (file-name-nondirectory dir)))
>> (when (and default-filename (not (zerop (length file))))
>> (setq default-filename file)
>> (setq dir (file-name-directory dir)))
>>
>> The third line makes more sense to me as:
>>
>> (when (and (not default-filename) (not (zerop (length file))))
>>
>> ie. if default-filename is specified, then the splitting should NOT be
>> done.
> That seems right to me. Stefan, you were the one who rewrote
> read-file-name; could you verify this?
Yes, it looks right,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-08 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-08 20:05 bug#2585: 23.0.90; read-file-name with dialog Chong Yidong
2009-03-08 20:24 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2009-03-06 18:41 MJ
2009-03-07 7:50 ` Jason Rumney
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.