From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 2585@emacsbugs.donarmstrong.com, MJ <mj54590@gmail.com>
Subject: bug#2585: 23.0.90; read-file-name with dialog
Date: Sun, 08 Mar 2009 16:24:44 -0400 [thread overview]
Message-ID: <jwveix7lq4i.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87fxhnok4m.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 08 Mar 2009 16:05:45 -0400")
>> Whoever did the conversion of read-file-name from C to lisp probably
>> knows what was meant by this, by my naive impression is that the
>> following logic is a mistake:
>>
>> ;; If DIR contains a file name, split it.
>> (let ((file (file-name-nondirectory dir)))
>> (when (and default-filename (not (zerop (length file))))
>> (setq default-filename file)
>> (setq dir (file-name-directory dir)))
>>
>> The third line makes more sense to me as:
>>
>> (when (and (not default-filename) (not (zerop (length file))))
>>
>> ie. if default-filename is specified, then the splitting should NOT be
>> done.
> That seems right to me. Stefan, you were the one who rewrote
> read-file-name; could you verify this?
Yes, it looks right,
Stefan
next prev parent reply other threads:[~2009-03-08 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-08 20:05 bug#2585: 23.0.90; read-file-name with dialog Chong Yidong
2009-03-08 20:24 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-06 18:41 MJ
2009-03-07 7:50 ` Jason Rumney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwveix7lq4i.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=2585@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=mj54590@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.