From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Date: Tue, 18 Aug 2009 23:27:16 -0400 Message-ID: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <87ws52xhpi.fsf@mail.jurta.org> <87tz04pmzd.fsf@mail.jurta.org> Reply-To: Stefan Monnier , 4117@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250802640 10261 80.91.229.12 (20 Aug 2009 21:10:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Aug 2009 21:10:40 +0000 (UTC) Cc: Eli Barzilay , 4117@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 20 23:10:31 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeEtY-0003S8-Dh for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 23:10:04 +0200 Original-Received: from localhost ([127.0.0.1]:36184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeEtX-0007hl-Lf for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 17:10:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeEtS-0007dA-LS for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:09:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeEtN-0007Mf-PG for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:09:58 -0400 Original-Received: from [199.232.76.173] (port=55408 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeEtN-0007MG-L3 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:09:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52315) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeEtM-0007El-QV for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:09:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7KKkpo4019227; Thu, 20 Aug 2009 13:48:01 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7KKbFE5017398; Thu, 20 Aug 2009 13:37:15 -0700 Resent-Date: Thu, 20 Aug 2009 13:37:15 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 20 Aug 2009 20:37:15 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4117 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4117-submit@emacsbugs.donarmstrong.com id=B4117.125065244426746 (code B ref 4117); Thu, 20 Aug 2009 20:37:15 +0000 Original-Received: (at 4117) by emacsbugs.donarmstrong.com; 19 Aug 2009 03:27:24 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7J3RMXB026739 for <4117@emacsbugs.donarmstrong.com>; Tue, 18 Aug 2009 20:27:24 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnsFAKcNi0pFpaKZ/2dsb2JhbACBUsUGkUyEGQWHTw X-IronPort-AV: E=Sophos;i="4.43,406,1246852800"; d="scan'208";a="43768828" Original-Received: from 69-165-162-153.dsl.teksavvy.com (HELO pastel.home) ([69.165.162.153]) by ironport2-out.teksavvy.com with ESMTP; 18 Aug 2009 23:26:42 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E7E9382F0; Tue, 18 Aug 2009 23:27:16 -0400 (EDT) In-Reply-To: <87tz04pmzd.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 19 Aug 2009 03:56:06 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 20 Aug 2009 17:09:58 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30356 Archived-At: >> So stuffing it back into unread-command-events is incorrect. I think >> the right solution requires the use of something like >> this-single-command-raw-keys. > How this would help to reread a key sequence with Isearch > keymap deactivated (i.e. to do the same that > `isearch-reread-key-sequence-naturally' currently does)? I think it would make the funny business like (if (and (> (length keylist) 1) (symbolp (car keylist)) (listp (cadr keylist)) (not (numberp (posn-point (event-start (cadr keylist) ))))) (pop unread-command-events))) unnecessary, and it would fix various bugs such as the one discussed. `unread-command-events' should hold events that have not gone through input-decode-map, function-key-map, dwon-mouse and drag-mouse demotion, double-click -> click demotion, shift->unshift demotion, ... i.e. raw-events. So isearch-unread should be called with events that come from read-event or from this-single-command-raw-keys but not from read-key-sequence. Stefan