bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

[Lennart Borgman]

c-newline-and-indent calls indent-according-to-mode to get indentation
right for a major mode. However in the case of multiple major modes in a
buffer (not yet part of Emacs) the current major mode is not enough to
know to get the indentation correct.

MuMaMo (a framework for multiple major modes in a buffer) therefore
instead sets indent-line-function which is more flexible. However when
the user uses c-electric-semi&comma this is bypassed since this
function calls c-newline-and-indent.

I just got a bug report where this problem shows up:

  https://bugs.launchpad.net/nxhtml/+bug/463136

I do not know how to solve this problem, but perhaps is it possible that
c-newline-and-indent instead calls indent-line-function?


In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-10-15

bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

[Stefan Monnier]

> c-newline-and-indent calls indent-according-to-mode to get indentation
[...]
> I do not know how to solve this problem, but perhaps is it possible that
> c-newline-and-indent instead calls indent-line-function?

Why would that help?  indent-according-to-mode doesn't do much more than
call indent-line-function.


        Stefan

bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

[Lennart Borgman]

On Fri, Oct 30, 2009 at 2:08 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> c-newline-and-indent calls indent-according-to-mode to get indentation
> [...]
>> I do not know how to solve this problem, but perhaps is it possible that
>> c-newline-and-indent instead calls indent-line-function?
>
> Why would that help?  indent-according-to-mode doesn't do much more than
> call indent-line-function.

Eh, sorry.

Looking at the code in c-electric-semi&comma I think it is better to
change the call to (c-indent-line) currently on line 938 in cc-cmds.el
to (funcall indent-line-function). That will fix the problem I think.

	    (if c-syntactic-indentation
		;;(c-indent-line)
                (funcall indent-line-function)
              )

Would that be the right fix Alan?

bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

[Alan Mackenzie]

Hi, Lennart!

On Sat, Nov 21, 2009 at 03:09:08PM +0100, Lennart Borgman wrote:
> On Fri, Oct 30, 2009 at 2:08 AM, Stefan Monnier
> <monnier@iro.umontreal.ca> wrote:
> >> c-newline-and-indent calls indent-according-to-mode to get indentation
> > [...]
> >> I do not know how to solve this problem, but perhaps is it possible that
> >> c-newline-and-indent instead calls indent-line-function?

> > Why would that help?  indent-according-to-mode doesn't do much more than
> > call indent-line-function.

> Eh, sorry.

> Looking at the code in c-electric-semi&comma I think it is better to
> change the call to (c-indent-line) currently on line 938 in cc-cmds.el
> to (funcall indent-line-function). That will fix the problem I think.

> 	    (if c-syntactic-indentation
> 		;;(c-indent-line)
>                 (funcall indent-line-function)
>               )

> Would that be the right fix Alan?

I reckon so; it looks like a proper fix, not a workaround.  But if you
could comment it something like:

                 (funcall indent-line-function) ; Call indirectly for mumamo

, the chance of it being "cleaned up" at a later date would be
considerably diminished.	

If you want to commit this change, it's fine as far as I'm concerned.

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

[Lars Magne Ingebrigtsen]

Lennart Borgman <lennart.borgman@gmail.com> writes:

> Looking at the code in c-electric-semi&comma I think it is better to
> change the call to (c-indent-line) currently on line 938 in cc-cmds.el
> to (funcall indent-line-function). That will fix the problem I think.
>
> 	    (if c-syntactic-indentation
> 		;;(c-indent-line)
>                 (funcall indent-line-function)
>               )

The code seems to have changed a bit in the mean time -- line 938 no
longer has that code.

Is this still relevant?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4828: 23.1.50; c-newline-and-indent and indent-line-function

[Lars Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Lennart Borgman <lennart.borgman@gmail.com> writes:
>
>> Looking at the code in c-electric-semi&comma I think it is better to
>> change the call to (c-indent-line) currently on line 938 in cc-cmds.el
>> to (funcall indent-line-function). That will fix the problem I think.
>>
>> 	    (if c-syntactic-indentation
>> 		;;(c-indent-line)
>>                 (funcall indent-line-function)
>>               )
>
> The code seems to have changed a bit in the mean time -- line 938 no
> longer has that code.
>
> Is this still relevant?

More information was requested, but no response was given within a few
years, so I'm closing this bug report.  If the problem still exists,
please reopen this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no