From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5354: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode Date: Mon, 11 Jan 2010 12:37:25 -0500 Message-ID: References: Reply-To: Stefan Monnier , 5354@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263233003 26212 80.91.229.12 (11 Jan 2010 18:03:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jan 2010 18:03:23 +0000 (UTC) Cc: 5354@debbugs.gnu.org To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 11 19:03:15 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NUObi-0002NI-ET for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jan 2010 19:03:14 +0100 Original-Received: from localhost ([127.0.0.1]:54147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUObj-00087G-2O for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jan 2010 13:03:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUOOA-0003HO-Oq for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 12:49:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUOO6-0003Dr-4E for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 12:49:14 -0500 Original-Received: from [199.232.76.173] (port=60957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUOO5-0003DZ-MM for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 12:49:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37619) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUOO5-0008Mi-08 for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 12:49:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NUODK-00020S-AZ; Mon, 11 Jan 2010 12:38:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Stefan Monnier , 5354@debbugs.gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jan 2010 17:38:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5354 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5354-submit@debbugs.gnu.org id=B5354.12632314527692 (code B ref 5354); Mon, 11 Jan 2010 17:38:02 +0000 Original-Received: (at 5354) by debbugs.gnu.org; 11 Jan 2010 17:37:32 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUOCq-000201-1I for submit@debbugs.gnu.org; Mon, 11 Jan 2010 12:37:32 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUOCp-0001zr-0U for 5354@debbugs.gnu.org; Mon, 11 Jan 2010 12:37:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArMEAMbwSkvO+KPG/2dsb2JhbACBRNcYhC8Eiik X-IronPort-AV: E=Sophos;i="4.49,257,1262581200"; d="scan'208";a="53520204" Original-Received: from 206-248-163-198.dsl.teksavvy.com (HELO pastel.home) ([206.248.163.198]) by ironport2-out.pppoe.ca with ESMTP; 11 Jan 2010 12:37:25 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 685C481C9; Mon, 11 Jan 2010 12:37:25 -0500 (EST) In-Reply-To: (Lennart Borgman's message of "Mon, 11 Jan 2010 17:42:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.1 (--) Resent-Date: Mon, 11 Jan 2010 12:38:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34202 Archived-At: > In `js-mode' there is a call to `font-lock-fontify-buffer' at the end. > This creates problem for mumamo since it fontifies outside the region > where js-mode should be applied: > (let (font-lock-keywords) ; leaves syntactic keywords intact > (font-lock-fontify-buffer)) > Could this please be replaced by > (let (font-lock-keywords ; leaves syntactic keywords intact > font-lock-extend-region-functions) ;; accept narrowing > (font-lock-fontify-region (point-min) (point-max))) This looks majorly odd (aka difficult to explain/justify from js-mode's point of view). I suggest you instead submit a proposal for a new font-lock function that does what js-mode needs. Stefan