From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: log-edit-strip-single-file-name Date: Sat, 06 Feb 2010 09:28:36 -0500 Message-ID: References: <3a26oiti.fsf@fencepost.gnu.org> <12bpggw4wg.fsf@fencepost.gnu.org> <201001290820.o0T8KCv1022959@godzilla.ics.uci.edu> <201002040751.o147pVEb025009@godzilla.ics.uci.edu> <201002060426.o164QMaa000423@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1265466532 4611 80.91.229.12 (6 Feb 2010 14:28:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Feb 2010 14:28:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 06 15:28:50 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NdleR-0002et-Vi for ged-emacs-devel@m.gmane.org; Sat, 06 Feb 2010 15:28:48 +0100 Original-Received: from localhost ([127.0.0.1]:60974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NdleR-0001Ex-9N for ged-emacs-devel@m.gmane.org; Sat, 06 Feb 2010 09:28:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NdleM-0001E2-M3 for emacs-devel@gnu.org; Sat, 06 Feb 2010 09:28:42 -0500 Original-Received: from [199.232.76.173] (port=48676 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NdleL-0001Cr-HP for emacs-devel@gnu.org; Sat, 06 Feb 2010 09:28:41 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NdleK-000636-Bg for emacs-devel@gnu.org; Sat, 06 Feb 2010 09:28:41 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:8582 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NdleK-00062Y-1m for emacs-devel@gnu.org; Sat, 06 Feb 2010 09:28:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArEEALcLbUtFpaN9/2dsb2JhbACBM9QShFQEim6DLA X-IronPort-AV: E=Sophos;i="4.49,418,1262581200"; d="scan'208";a="55450169" Original-Received: from 69-165-163-125.dsl.teksavvy.com (HELO pastel.home) ([69.165.163.125]) by ironport2-out.pppoe.ca with ESMTP; 06 Feb 2010 09:28:36 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A34FA7F5A; Sat, 6 Feb 2010 09:28:36 -0500 (EST) In-Reply-To: <201002060426.o164QMaa000423@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 5 Feb 2010 20:26:22 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120982 Archived-At: >> > - (let ((variables-file (dir-locals-find-file (buffer-file-name))) >> > + (let ((variables-file (dir-locals-find-file (or dname (buffer-file-name)))) >> Why (or dname (buffer-file-name)) rather than (or buffer-file-name default-directory)? > It looked clearer to me. I think that using something else than default-directory would be a serious source of surprise for the user. > Can this patch go in? Not for 23.2, no. Stefan