From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: log-edit-strip-single-file-name
Date: Sat, 06 Feb 2010 09:28:36 -0500 [thread overview]
Message-ID: <jwveiky4ey7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <201002060426.o164QMaa000423@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 5 Feb 2010 20:26:22 -0800 (PST)")
>> > - (let ((variables-file (dir-locals-find-file (buffer-file-name)))
>> > + (let ((variables-file (dir-locals-find-file (or dname (buffer-file-name))))
>> Why (or dname (buffer-file-name)) rather than (or buffer-file-name default-directory)?
> It looked clearer to me.
I think that using something else than default-directory would be
a serious source of surprise for the user.
> Can this patch go in?
Not for 23.2, no.
Stefan
next prev parent reply other threads:[~2010-02-06 14:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 3:21 commit style redux Miles Bader
2009-04-01 0:57 ` Stefan Monnier
2010-01-16 3:00 ` Glenn Morris
2010-01-16 7:03 ` Juanma Barranquero
2010-01-16 9:10 ` Thien-Thi Nguyen
2010-01-27 4:25 ` Glenn Morris
2010-01-27 14:57 ` Stefan Monnier
2010-01-28 5:30 ` log-edit-strip-single-file-name [was Re: commit style redux] Glenn Morris
2010-01-28 19:25 ` log-edit-strip-single-file-name Stefan Monnier
2010-01-28 23:13 ` log-edit-strip-single-file-name Stefan Monnier
2010-01-29 3:06 ` log-edit-strip-single-file-name Dan Nicolaescu
2010-01-29 8:20 ` log-edit-strip-single-file-name Dan Nicolaescu
2010-01-29 17:58 ` log-edit-strip-single-file-name Stefan Monnier
2010-02-04 7:51 ` log-edit-strip-single-file-name Dan Nicolaescu
2010-02-04 15:40 ` log-edit-strip-single-file-name Stefan Monnier
2010-02-06 4:26 ` log-edit-strip-single-file-name Dan Nicolaescu
2010-02-06 14:28 ` Stefan Monnier [this message]
2010-02-06 19:18 ` log-edit-strip-single-file-name Dan Nicolaescu
2010-02-08 1:28 ` log-edit-strip-single-file-name Stefan Monnier
2010-01-30 22:57 ` log-edit-strip-single-file-name Juri Linkov
2010-01-31 6:56 ` log-edit-strip-single-file-name Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwveiky4ey7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.