From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: which-function => DEFUN? Date: Mon, 10 May 2010 11:42:19 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1273506162 22512 80.91.229.12 (10 May 2010 15:42:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 10 May 2010 15:42:42 +0000 (UTC) Cc: Lennart Borgman , Emacs-Devel devel To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 10 17:42:41 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OBV7w-00027E-1w for ged-emacs-devel@m.gmane.org; Mon, 10 May 2010 17:42:40 +0200 Original-Received: from localhost ([127.0.0.1]:55181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBV7v-0005je-EU for ged-emacs-devel@m.gmane.org; Mon, 10 May 2010 11:42:39 -0400 Original-Received: from [140.186.70.92] (port=37289 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBV7i-0005eA-UE for emacs-devel@gnu.org; Mon, 10 May 2010 11:42:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBV7d-0004nG-Ti for emacs-devel@gnu.org; Mon, 10 May 2010 11:42:26 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:17981 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBV7d-0004mt-NT for emacs-devel@gnu.org; Mon, 10 May 2010 11:42:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAJ7G50tLd+Zs/2dsb2JhbACeH3K9VYJZgjsEjDI X-IronPort-AV: E=Sophos;i="4.52,362,1270440000"; d="scan'208";a="63825137" Original-Received: from 75-119-230-108.dsl.teksavvy.com (HELO pastel.home) ([75.119.230.108]) by ironport2-out.pppoe.ca with ESMTP; 10 May 2010 11:42:19 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7D6B48205; Mon, 10 May 2010 11:42:19 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Mon, 10 May 2010 16:22:30 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124664 Archived-At: > (defun which-func-identify-DEFUN () > (save-excursion > (save-match-data > (beginning-of-defun) > (and (looking-at "DEFUN +(\"[^\"]+\",[ \n]+\\(F[^,]+\\),") > (match-string-no-properties 1))))) > Likely the `save-match-data' is not required, but I tend to err on the > side of saving it on my code. The rule for where to place a save-match-data is: around the code run between "looking-at" and "match-string-no-properties". In this case (as in 99% of the cases) this code is empty, so the save-match-data can be dropped. > (add-hook 'which-func-functions 'which-func-identify-DEFUN nil t) If your save-match-data were needed, which-func-functions should say so explicitly. Stefan