From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: theme and a question about creating them
Date: Thu, 20 Jan 2011 10:46:21 -0500 [thread overview]
Message-ID: <jwvei87wpiz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87vd1kmg17.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 19 Jan 2011 22:04:52 -0500")
>> It doesn't make much sense to run the theme through `unsafep' while
>> marking `custom-theme-set-variables' and `custom-theme-set-faces' as
>> "safe functions" (which they aren't).
> A user who loads a theme would expects it to do *something*, so I'd
> argue that those two functions should not be considered unsafe while
> performing such an operation.
But if it sets a hook to trigger a nuclear explosion, the user might
be in for a nasty surprise.
> If this really is a concern, how bout marking only
> custom-theme-set-faces as safe? Then the user can be prompted for any
> (non-built-in) theme that changes variables, but themes that only
> fiddle with faces will be accepted.
I guess that one could be safe, tho IIRC we can set :height to
a function, so there's still a risk.
Stefan
prev parent reply other threads:[~2011-01-20 15:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 15:52 theme and a question about creating them Dirk-Jan C. Binnema
2011-01-02 14:16 ` Chong Yidong
2011-01-02 17:38 ` Yavuz
2011-01-05 19:26 ` Dirk-Jan C. Binnema
2011-01-05 21:05 ` Stefan Monnier
2011-01-05 22:30 ` Johan Bockgård
2011-01-07 3:36 ` Stefan Monnier
2011-01-08 3:12 ` Johan Bockgård
2011-01-08 5:26 ` Stefan Monnier
2011-01-11 18:57 ` Johan Bockgård
2011-01-06 0:49 ` Chong Yidong
2011-01-08 19:28 ` Chong Yidong
2011-01-15 0:48 ` Johan Bockgård
2011-01-19 22:42 ` Johan Bockgård
2011-01-20 3:04 ` Chong Yidong
2011-01-20 15:46 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvei87wpiz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.