From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] make-docfile: don't corrupt heap for an invalid .elc file Date: Sun, 30 Jan 2011 22:33:46 -0500 Message-ID: References: <87wrlsqj3m.fsf@meyering.net> <87r5bu7nn2.fsf@meyering.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296444839 9785 80.91.229.12 (31 Jan 2011 03:33:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Jan 2011 03:33:59 +0000 (UTC) Cc: Emacs development discussions To: Jim Meyering Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 31 04:33:54 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PjkWY-0000BD-NZ for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 04:33:54 +0100 Original-Received: from localhost ([127.0.0.1]:33756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjkWY-0002Kp-8O for ged-emacs-devel@m.gmane.org; Sun, 30 Jan 2011 22:33:54 -0500 Original-Received: from [140.186.70.92] (port=33171 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjkWT-0002Kk-5R for emacs-devel@gnu.org; Sun, 30 Jan 2011 22:33:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjkWR-0006zp-U4 for emacs-devel@gnu.org; Sun, 30 Jan 2011 22:33:48 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26389 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjkWR-0006zk-OH for emacs-devel@gnu.org; Sun, 30 Jan 2011 22:33:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEADy8RU1MCpTp/2dsb2JhbACkdHS5JoVOBIUTj2g X-IronPort-AV: E=Sophos;i="4.60,402,1291611600"; d="scan'208";a="89879991" Original-Received: from 76-10-148-233.dsl.teksavvy.com (HELO ceviche.home) ([76.10.148.233]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 30 Jan 2011 22:33:47 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id CE45A660DC; Sun, 30 Jan 2011 22:33:46 -0500 (EST) In-Reply-To: <87r5bu7nn2.fsf@meyering.net> (Jim Meyering's message of "Sun, 30 Jan 2011 10:21:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135262 Archived-At: >> "printf '#@1' > in.elc; ./make-docfile in.elc" would write a '\0' >> one byte before the just-malloc'd saved_string buffer. >> * make-docfile.c (scan_lisp_file): Diagnose an invalid dynamic >> doc string length. Also fix an always-false while-loop test. > I committed this to master. Thanks, Stefan