From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Proposal: window-system-version function Date: Mon, 21 May 2012 12:03:39 -0400 Message-ID: References: <4FBA4CF6.1030007@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337616233 23753 80.91.229.3 (21 May 2012 16:03:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 May 2012 16:03:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 21 18:03:53 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SWV5K-0006w5-Lk for ged-emacs-devel@m.gmane.org; Mon, 21 May 2012 18:03:50 +0200 Original-Received: from localhost ([::1]:60651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWV5K-00079i-64 for ged-emacs-devel@m.gmane.org; Mon, 21 May 2012 12:03:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWV5H-00079Q-Jx for emacs-devel@gnu.org; Mon, 21 May 2012 12:03:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWV5C-0005qj-32 for emacs-devel@gnu.org; Mon, 21 May 2012 12:03:47 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:10251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWV5B-0005qL-VO for emacs-devel@gnu.org; Mon, 21 May 2012 12:03:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAOMAh0/O+K+j/2dsb2JhbAA3o0KBCIF1AQEEAVYjBQsLDiYSFBgNJIgTohGMF00JAwECgz4Dg3AEo2OEWA X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="181593217" Original-Received: from 206-248-175-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.175.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 May 2012 12:03:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 01A9E59198; Mon, 21 May 2012 12:03:39 -0400 (EDT) In-Reply-To: <4FBA4CF6.1030007@yandex.ru> (Dmitry Antipov's message of "Mon, 21 May 2012 18:11:02 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.143.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150581 Archived-At: > This patch replaces global variable 'window-system-version' with the function > which returns the window system version for the specified frame. An obvious > reason for this is to have correct results when Emacs is running with both > TTY and X frames. The general idea of the patch is right, the implementation looks OK as well, but I have one major issue with it: why do we ever need to know the "version" of the window-system? I've only ever seen it used to display diagnostic data, i.e. to help debug some problem, but I've never found it useful when debugging. IOW, I'd much rather mark window-system-version as obsolete. Stefan