From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Date: Sun, 03 Jun 2012 11:18:23 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338736765 17782 80.91.229.3 (3 Jun 2012 15:19:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2012 15:19:25 +0000 (UTC) Cc: 11606@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 17:19:22 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SbCaK-0005iu-3m for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 17:19:16 +0200 Original-Received: from localhost ([::1]:44516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbCaJ-0005Lk-RQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 11:19:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbCaG-0005L7-Ng for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:19:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbCaF-000657-2G for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:19:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbCaE-000653-V6 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:19:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SbCc2-0003Fu-E3 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2012 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11606-submit@debbugs.gnu.org id=B11606.133873684012485 (code B ref 11606); Sun, 03 Jun 2012 15:21:02 +0000 Original-Received: (at 11606) by debbugs.gnu.org; 3 Jun 2012 15:20:40 +0000 Original-Received: from localhost ([127.0.0.1]:55916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbCbg-0003FK-Kr for submit@debbugs.gnu.org; Sun, 03 Jun 2012 11:20:40 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:19064) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbCbN-0003En-1J for 11606@debbugs.gnu.org; Sun, 03 Jun 2012 11:20:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+UI/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="187797018" Original-Received: from 108-175-229-8.dsl.teksavvy.com (HELO pastel.home) ([108.175.229.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jun 2012 11:18:23 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3673259607; Sun, 3 Jun 2012 11:18:23 -0400 (EDT) In-Reply-To: (Leo's message of "Sun, 03 Jun 2012 12:05:56 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60673 Archived-At: >> I also like removing those, but I still don't know why you think these >> can be removed safely. > I was thinking that add-hook supports adding local hooks which might be > better than making those hooks buffer-local. That's generally true, but (add-hook 'foo 'bar) operates on the local part if the var is `make-variable-buffer-local', so the removal you suggest would break code that relies on this detail. > What are your concerns about their safety? My concern is that I know nothing about these variables, so I have no way to judge whether removing those things is safe. Stefan