From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: 11606@debbugs.gnu.org
Subject: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el
Date: Sun, 03 Jun 2012 11:18:23 -0400 [thread overview]
Message-ID: <jwvehpwctnr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m17gvpxcnv.fsf@gmail.com> (Leo's message of "Sun, 03 Jun 2012 12:05:56 +0800")
>> I also like removing those, but I still don't know why you think these
>> can be removed safely.
> I was thinking that add-hook supports adding local hooks which might be
> better than making those hooks buffer-local.
That's generally true, but (add-hook 'foo 'bar) operates on the local
part if the var is `make-variable-buffer-local', so the removal you
suggest would break code that relies on this detail.
> What are your concerns about their safety?
My concern is that I know nothing about these variables, so I have no
way to judge whether removing those things is safe.
Stefan
next prev parent reply other threads:[~2012-06-03 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 4:44 bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Leo
2012-06-02 17:57 ` Stefan Monnier
2012-06-03 2:07 ` Leo
2012-06-03 3:18 ` Stefan Monnier
2012-06-03 4:05 ` Leo
2012-06-03 15:18 ` Stefan Monnier [this message]
2012-06-05 16:14 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvehpwctnr.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11606@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.