From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] partial revert of overlays (+patch) Date: Mon, 13 Aug 2012 17:01:54 -0400 Message-ID: References: <5028F7E8.9000304@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344891745 19066 80.91.229.3 (13 Aug 2012 21:02:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Aug 2012 21:02:25 +0000 (UTC) Cc: Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 13 23:02:23 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T11mC-00038H-9S for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2012 23:02:16 +0200 Original-Received: from localhost ([::1]:42384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11mB-0005YB-6j for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2012 17:02:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11m7-0005Ws-NL for emacs-devel@gnu.org; Mon, 13 Aug 2012 17:02:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T11m5-0003TZ-ET for emacs-devel@gnu.org; Mon, 13 Aug 2012 17:02:11 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11m5-0003TT-9M for emacs-devel@gnu.org; Mon, 13 Aug 2012 17:02:09 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q7DL1taU017723; Mon, 13 Aug 2012 17:02:02 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 7F168AE427; Mon, 13 Aug 2012 17:01:54 -0400 (EDT) In-Reply-To: <5028F7E8.9000304@yandex.ru> (Dmitry Antipov's message of "Mon, 13 Aug 2012 16:49:44 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4309=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4309> : streams <798792> : uri <1191513> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152496 Archived-At: > OK, this is the partial revert: OV_xxx are dropped, > buffer_set_overlays_(before|after) are used to set an appropriate > pointers, and the rest is not touched (I suppose that unchain_both > and buffer_has_overlays are OK). Looks OK, thank you. > - for (ov = buffer_get_overlays (b, OV_BEFORE); ov; ov = next) > - { > - drop_overlay (b, ov); > - next = ov->next; > - ov->next = NULL; > - } > - > - for (ov = buffer_get_overlays (b, OV_AFTER); ov; ov = next) > - { > - drop_overlay (b, ov); > - next = ov->next; > - ov->next = NULL; > - } > - > - buffer_set_overlays (b, NULL, OV_BEFORE); > - buffer_set_overlays (b, NULL, OV_AFTER); > + for (ov = b->overlays_before; ov; ov = next) > + { > + drop_overlay (b, ov); > + next = ov->next; > + ov->next = NULL; > + } > + > + for (ov = b->overlays_after; ov; ov = next) > + { > + drop_overlay (b, ov); > + next = ov->next; > + ov->next = NULL; > + } > + > + buffer_set_overlays_before (b, NULL); > + buffer_set_overlays_after (b, NULL); How did you get this hunk? Most of the lines seem 100% completely totally unmodified and yet they appear as + and -. Stefan