random 1 second delay in comint-redirect-results-list-from-process

random 1 second delay in comint-redirect-results-list-from-process

[Leo Liu]

Hi there,

I am seeing seemingly random delay of 1 second when using
comint-redirect-results-list-from-process, which may be the fault of
(accept-process-output nil 1).

Could someone explain (accept-process-output nil 1)? Any harm in
reducing it to (accept-process-output nil)?

Leo

Re: random 1 second delay in comint-redirect-results-list-from-process

[Stefan Monnier]

> Could someone explain (accept-process-output nil 1)? Any harm in
> reducing it to (accept-process-output nil)?

Rather than nil it should pass the actual process.


        Stefan

Re: random 1 second delay in comint-redirect-results-list-from-process

[Leo Liu]

On 2013-06-20 10:16 +0800, Stefan Monnier wrote:
> Rather than nil it should pass the actual process.

Is it OK to apply the following patch?

=== modified file 'lisp/comint.el'
--- lisp/comint.el      2013-05-25 02:40:33 +0000
+++ lisp/comint.el      2013-06-20 05:14:25 +0000
@@ -3726,7 +3726,7 @@
       ;; Wait for the process to complete
       (set-buffer (process-buffer process))
       (while (null comint-redirect-completed)
-       (accept-process-output nil 1))
+       (accept-process-output process))
       ;; Collect the output
       (set-buffer output-buffer)
       (goto-char (point-min))

Re: random 1 second delay in comint-redirect-results-list-from-process

[Stefan Monnier]

>        (while (null comint-redirect-completed)
> -       (accept-process-output nil 1))
> +       (accept-process-output process))

I think it's OK, tho I think the loop should of course check the return
value of accept-process-output (or else, check that the process is
still running).


        Stefan