From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14702: 24.3.50; Byte-compiling called-interactively-p inside catch Date: Mon, 24 Jun 2013 21:39:21 -0400 Message-ID: References: <87zjufd1ks.fsf@rosalinde.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372124410 11353 80.91.229.3 (25 Jun 2013 01:40:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Jun 2013 01:40:10 +0000 (UTC) Cc: 14702@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 03:40:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrIEr-0005I4-6B for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2013 03:40:09 +0200 Original-Received: from localhost ([::1]:57736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrIEq-0002Yl-PU for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2013 21:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrIEm-0002XB-Uf for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2013 21:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrIEl-0003Mk-Ur for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2013 21:40:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrIEl-0003La-R8 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2013 21:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UrIEk-00057x-VM for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2013 21:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2013 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14702-submit@debbugs.gnu.org id=B14702.137212437019625 (code B ref 14702); Tue, 25 Jun 2013 01:40:02 +0000 Original-Received: (at 14702) by debbugs.gnu.org; 25 Jun 2013 01:39:30 +0000 Original-Received: from localhost ([127.0.0.1]:39232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrIED-00056Q-AF for submit@debbugs.gnu.org; Mon, 24 Jun 2013 21:39:29 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:22952) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrIEB-000567-AL for 14702@debbugs.gnu.org; Mon, 24 Jun 2013 21:39:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17084552" Original-Received: from 76-10-154-64.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Jun 2013 21:39:16 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2FCC5AE246; Mon, 24 Jun 2013 21:39:21 -0400 (EDT) In-Reply-To: <87zjufd1ks.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Mon, 24 Jun 2013 16:29:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75541 Archived-At: > (defun baz () > (interactive) > (catch 'test > (if (called-interactively-p 'any) If it hurts, don't do that. Internally, the byte-compiled form of catch ends up wrapping its body inside a lambda, so the called-interactively-p test refers to the implicit lambda added, rather than to the enclosing function you defined. It would be good to avoid this intermediate lambda for performance reasons (which would incidentally also fix this particular issue), but in the mean time (and more generally) either avoid called-interactively-p (pass an extra argument instead), or avoid placing it "deep" within your function (e.g. inside a catch/unwind-protect/condition-case/save-foobar/...). Stefan