From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Fri, 29 Nov 2013 12:04:05 -0500 Message-ID: References: <871u1zes89.fsf@yandex.ru> <5298AA77.4060009@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385744704 20581 80.91.229.3 (29 Nov 2013 17:05:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Nov 2013 17:05:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 29 18:05:09 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmRV3-0006fk-Ss for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 18:05:06 +0100 Original-Received: from localhost ([::1]:48533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmRV3-0000Xw-EF for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 12:05:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmRUE-0007Xa-Bg for emacs-devel@gnu.org; Fri, 29 Nov 2013 12:04:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmRU6-0000zV-QT for emacs-devel@gnu.org; Fri, 29 Nov 2013 12:04:14 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:37703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmRU6-0000zF-N2 for emacs-devel@gnu.org; Fri, 29 Nov 2013 12:04:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40699622" Original-Received: from 206-248-161-33.dsl.teksavvy.com (HELO pastel.home) ([206.248.161.33]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Nov 2013 12:04:05 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id C63E460EFA; Fri, 29 Nov 2013 12:04:05 -0500 (EST) In-Reply-To: <5298AA77.4060009@yandex.ru> (Dmitry Gutov's message of "Fri, 29 Nov 2013 16:53:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165885 Archived-At: >> The intention was to remind people that they should think about who's >> the author. Indeed, it's particularly useful for us but less so for >> many other projects. > Isn't it too late to remind when the log-edit buffer is open? Normally, you > create ChangeLog entries first (and they should include the right author), > only then open the vc-dir buffer, mark the files and then see the > log-edit buffer. I think of this "reminding" as a process rather than a one-time event, so I'm not too worried about it being "too late". It's not perfect, but it's better than nothing, I think. >> Maybe we can set it as a .dir-locals.el customization. > It would be better, but since dir-locals overrides personal customizations, > it wouldn't be ideal either, as far as I'm concerned. Having an extra empty "Author:" field might hurt your aesthetic sensibility, but I don't see how it could be really harmful, so I think it's perfectly OK even if it's hard to override (and of course, it can still be overridden, if you're sufficiently motivated). >> The RFC822 format does add features, since there are a few other special >> headers (Author, Fixes, Amend, maybe a few more). > True. But is it relevant to the question of whether to include the Summary > and Author headers by default? What would you include, instead? > Another problem with Summary, I believe, is that it's often unused in Emacs > commit messages. IIUC that's a problem in Emacs's commit messages, not in vc-log-edit, and the presence of the "Summary:" header might actually encourage people to change their habit. >> We should also use some of the message-mode commands to move inside the >> header, as was suggested here recently. > Not sure which thread, or which commands you mean. But `C-e' works well > enough for moving after "Summary:". C-a could move to "right after the :". >> Indeed, that needs to be fixed. It's easy to fix when we kill the >> *vc-log* buffer, but it might be trickier to fix when you just >> bury-it :( > Since bury-buffer doesn't have a default binding in log-edit, I think that's > not much of a problem. But we can follow Magit's (and message-mode's) > example and create a command that would do the burying the smart way (and > bind it to C-c C-k). Sounds good. >> Maybe log-edit-show-files shouldn't be in the default log-edit-hook. > I'd rather we fix it than hide it. OK. > Another approach would be to instead of creating a separate buffer and > window, output its text at the bottom of the log-edit buffer. And > either make it a read-only-not-real text, or comment it out somehow > and remove that section before the commit is made. These could work as well, indeed. Stefan