From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14941: [Patch] Lighten up wrt version specification Date: Thu, 13 Mar 2014 09:35:48 -0400 Message-ID: References: <8b0062be-4eb9-4cfe-a994-5dbdeec4eb93@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394717818 3770 80.91.229.3 (13 Mar 2014 13:36:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Mar 2014 13:36:58 +0000 (UTC) Cc: 14941-done@debbugs.gnu.org To: Tom Willemse Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 13 14:37:05 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WO5om-0007w4-EX for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 14:37:04 +0100 Original-Received: from localhost ([::1]:38965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5om-0003cg-3a for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 09:37:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5nw-000251-NV for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:36:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO5np-0001cz-CR for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:36:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5np-0001cv-9U for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:36:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WO5no-0005JG-Bq for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 09:36:04 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Mar 2014 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 14941@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com Original-Received: via spool by 14941-done@debbugs.gnu.org id=D14941.139471775820391 (code D ref 14941); Thu, 13 Mar 2014 13:36:02 +0000 Original-Received: (at 14941-done) by debbugs.gnu.org; 13 Mar 2014 13:35:58 +0000 Original-Received: from localhost ([127.0.0.1]:35483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO5ng-0005Io-VY for submit@debbugs.gnu.org; Thu, 13 Mar 2014 09:35:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24665) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO5nZ-0005IZ-Mw for 14941-done@debbugs.gnu.org; Thu, 13 Mar 2014 09:35:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51710027" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Mar 2014 09:35:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id D46DD6057F; Thu, 13 Mar 2014 09:35:48 -0400 (EDT) In-Reply-To: (Tom Willemse's message of "Fri, 21 Feb 2014 00:19:42 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86815 Archived-At: > @@ -1128,6 +1128,8 @@ > ((symbolp dep) `(,dep "0")) > ((stringp dep) > (error "Invalid requirement specifier: %S" dep)) > + ((and (listp dep) (null (cdr dep))) > + (list (car dep) "0")) > (t dep))) > deps)))) I installed this hunk, but not the other. If a "Version:" header is missing, it should stay as an error, because package.el relies heavily on version numbers. And if the user can write "Version:" she can just as easily write "Version:0". Stefan