all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: Eli Barzilay <eli@barzilay.org>, 17759-done@debbugs.gnu.org
Subject: bug#17759: 24.4.50; Missing 'ascii-character props
Date: Sat, 14 Jun 2014 17:15:18 -0400	[thread overview]
Message-ID: <jwvegyrdwjl.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87bntv95w4.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 14 Jun 2014 12:50:35 +0300")

>>> +	(when (and (characterp normal) (eq (char-charset normal) 'ascii))
>> Do you really need the (eq (char-charset normal) 'ascii) test?
>> The `ascii-character' property doesn't have to be "ascii", really (the
>> name is just a historical accident which dates back to many moons ago
>> when ascii meant "plain text"), IIRC it just has to be a "real"
>> character as opposed to something with modifiers like ?\M-\A-x.

> Yes, the name is confusing, so I installed it without the ascii test.

I think we could largely get rid of this ascii-character property: it's
only used in `read-char' and in 99% of the case we could advantageously
replace `read-char' with something that uses `read-key' instead (where
the translation from an event to a character is done via
function-key-map instead of ascii-character).


        Stefan





      reply	other threads:[~2014-06-14 21:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 10:32 bug#17759: 24.4.50; Missing 'ascii-character props Eli Barzilay
2014-06-13  6:30 ` Juri Linkov
2014-06-13 12:46   ` Stefan Monnier
2014-06-14  9:50     ` Juri Linkov
2014-06-14 21:15       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvegyrdwjl.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17759-done@debbugs.gnu.org \
    --cc=eli@barzilay.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.