From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18182: 24.3.92; C-[ does not work as ESC in viper-mode Date: Mon, 18 Aug 2014 22:22:59 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1408415068 2461 80.91.229.3 (19 Aug 2014 02:24:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Aug 2014 02:24:28 +0000 (UTC) Cc: 18182@debbugs.gnu.org To: iquiw Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 19 04:24:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XJZ5w-0007ft-Iy for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Aug 2014 04:24:20 +0200 Original-Received: from localhost ([::1]:47436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJZ5w-0008Pa-4J for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Aug 2014 22:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJZ5l-0008OS-NP for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 22:24:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJZ5e-0004f5-7C for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 22:24:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJZ5e-0004f1-3w for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 22:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XJZ5d-0006HF-QY for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 22:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Aug 2014 02:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18182-submit@debbugs.gnu.org id=B18182.140841499924074 (code B ref 18182); Tue, 19 Aug 2014 02:24:01 +0000 Original-Received: (at 18182) by debbugs.gnu.org; 19 Aug 2014 02:23:19 +0000 Original-Received: from localhost ([127.0.0.1]:46796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XJZ4w-0006GE-SM for submit@debbugs.gnu.org; Mon, 18 Aug 2014 22:23:19 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:3435) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XJZ4u-0006G1-AQ for 18182@debbugs.gnu.org; Mon, 18 Aug 2014 22:23:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWFQ4FCws0EhQYDSSIBAjSGReOegeEOASrA4NMIQ X-IPAS-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWFQ4FCws0EhQYDSSIBAjSGReOegeEOASrA4NMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="87136162" Original-Received: from 192-171-34-171.cpe.pppoe.ca (HELO pastel.home) ([192.171.34.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Aug 2014 22:23:10 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id CD455615CF; Mon, 18 Aug 2014 22:22:59 -0400 (EDT) In-Reply-To: (iquiw's message of "Sun, 3 Aug 2014 21:43:44 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92524 Archived-At: > The following steps reproduce the problem. > 1. Run "emacs -Q". > 2. Type "M-x viper" to enable viper-mode. > 3. Type "i" to enter viper insert mode. > 4. Type "C-[". > On Emacs 24.3, it exits from viper insert mode as well as ESC key does. > On Emacs 24.3.92, it displays "ESC-" in minibuffer and does not exit > from viper insert mode. In Emacs-24.4, Viper's escape key sequence (in viper-ESC-key) was changed from [?\e] to [escape], i.e. from the ASCII escape char (usually called ESC in Emacs) to the `escape' key (usually called `escape' in Emacs). When `escape' has no specific binding, Emacs remaps it to ESC (via function-key-map), so previously the `escape' key worked to trigger the ESC binding of Viper. The C-[ key is an alias (at a lower level) for the ESC char, so indeed now it doesn't work any more to trigger the "viper-ESC-key" behavior. Actually it still works under a tty, since under a tty Viper receives ESC (rather than `escape') when you hit the escape key, so it has special code that maps this ESC to an `escape' (but only for tty frames, not in GUI frames). I think the hack below should work. Can you confirm it works for you? Stefan === modified file 'lisp/emulation/viper.el' --- lisp/emulation/viper.el 2014-06-29 02:33:50 +0000 +++ lisp/emulation/viper.el 2014-08-19 02:22:11 +0000 @@ -600,6 +600,9 @@ )) (viper-set-expert-level 'dont-change-unless))) + (if (equal viper-ESC-key [escape]) + (define-key function-key-map [?\e] [escape])) + (or (memq major-mode viper-emacs-state-mode-list) ; don't switch to Vi (memq major-mode viper-insert-state-mode-list) ; don't switch (viper-change-state-to-vi))