From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Proposed extension of show-paren-mode: Highlight parens when point is in L or R margin. Date: Thu, 16 Oct 2014 20:14:57 -0400 Message-ID: References: <20141012100416.GC3148@acm.acm> <20141015091208.GA3093@acm.acm> <20141016095326.GC3421@acm.acm> <20141016133137.GE3421@acm.acm> <20141016154610.GF3421@acm.acm> <20141016212648.GG3421@acm.acm> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1413504935 12178 80.91.229.3 (17 Oct 2014 00:15:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Oct 2014 00:15:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 17 02:15:28 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XevCa-0005Q1-B5 for ged-emacs-devel@m.gmane.org; Fri, 17 Oct 2014 02:15:28 +0200 Original-Received: from localhost ([::1]:55205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XevCZ-0004rU-Tg for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2014 20:15:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XevCE-0004oC-4V for emacs-devel@gnu.org; Thu, 16 Oct 2014 20:15:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XevC6-0002vS-LZ for emacs-devel@gnu.org; Thu, 16 Oct 2014 20:15:06 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:41574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XevC6-0002uk-Ht for emacs-devel@gnu.org; Thu, 16 Oct 2014 20:14:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoFxgVsh X-IPAS-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoFxgVsh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="94394158" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Oct 2014 20:14:57 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A50B285A2; Thu, 16 Oct 2014 20:14:57 -0400 (EDT) In-Reply-To: <20141016212648.GG3421@acm.acm> (Alan Mackenzie's message of "Thu, 16 Oct 2014 21:26:48 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175496 Archived-At: >> Otherwise it seems way too weird/ad-hoc to hardcode it, so make >> it dependent on a config var. > I think that our marginal utility will drop off very sharply, the more > complicated our configurability becomes. The purpose is not really to make it configurable, but to isolate the code that provides this part of the functionality. > Since point is on the same line as the paren, and is in the WS at either > BOL or EOL, and the (at most) two eligible parameters are on the edge of > the "core", point can't be between the two candidates. The nearest one > is clear, surely. Right, I was thinking about the case in my suggestion of highlighting the closing paren in at the end of the previous line. > Hmm. The :prefix keyword for `defgroup' is not mentioned in the doc > string for `defcustom' (which is where `defgroup' points you for details > of keywords). I think the :prefix only makes sense for defgroup, not for defcustom. Many keywords are like that, so maybe defgroup shouldn't delegate to defcustom's docstring. > I've removed all the instances of :group. Thanks. > Done. (More precisely, a function to do the check is called directly > from s-p--categorize-p). Yup, looks nice, thanks. Stefan