all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Make `package-install-from-buffer' work on directories
Date: Tue, 13 Jan 2015 14:39:12 -0500	[thread overview]
Message-ID: <jwvegqy4goh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAAdUY-JrRRhuGfzKhakh=t6Zpz9v=QnupRXWiH8-_gYdS5LCoA@mail.gmail.com> (Artur Malabarba's message of "Tue, 13 Jan 2015 13:26:55 -0200")

> The following patch to `package.el' makes it so that
> `package-install-from-buffer' (and `install-file') works on dired buffers.
> Before, they'd just work on .el and .tar files.

Sounds useful (my own install.el of years ago offered that same
functionality ;-).

I wonder about the implications of having a new `dir' value for
package-desc-kind.  Please add a comment somewhere discussing when
exactly that value can appear (since AFAICT you haven't updated all
uses of package-desc-kind to accommodate that new value, and I think
this value can indeed only appear in some of those uses).


        Stefan



  reply	other threads:[~2015-01-13 19:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 15:26 [PATCH] Make `package-install-from-buffer' work on directories Artur Malabarba
2015-01-13 19:39 ` Stefan Monnier [this message]
2015-01-14 11:47   ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvegqy4goh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.