bug#19786: 25.0.50; broken build (Attempt to modify RO object)

bug#19786: 25.0.50; broken build (Attempt to modify RO object)

[Mark Oteiza]

On current HEAD:

In toplevel form:
progmodes/gdb-mi.el:92:1:Error: Attempt to modify read-only object: (error)
Makefile:287: recipe for target 'progmodes/gdb-mi.elc' failed
make[2]: *** [progmodes/gdb-mi.elc] Error 1
make[2]: *** Waiting for unfinished jobs....

In end of data:
progmodes/cc-defs.el:2454:1:Warning: the following functions might not be
    defined at runtime: cc-bytecomp-restore-environment,
    cc-bytecomp-setup-environment, cc-bytecomp-load,
    cc-bytecomp-compiling-or-loading
make[2]: Leaving directory '/tmp/makepkg/emacs-git/src/emacs/lisp'
Makefile:310: recipe for target 'compile-main' failed
make[1]: *** [compile-main] Error 2
make[1]: Leaving directory '/tmp/makepkg/emacs-git/src/emacs/lisp'
Makefile:385: recipe for target 'lisp' failed
make: *** [lisp] Error 2

bug#19786: 25.0.50; broken build (Attempt to modify RO object)

[Lars Ingebrigtsen]

Mark Oteiza <mvoteiza@udel.edu> writes:

> In toplevel form:
> progmodes/gdb-mi.el:92:1:Error: Attempt to modify read-only object: (error)
> Makefile:287: recipe for target 'progmodes/gdb-mi.elc' failed
> make[2]: *** [progmodes/gdb-mi.elc] Error 1
> make[2]: *** Waiting for unfinished jobs....

This was due to the new error object in json.el which inherited from a
list of error conditions, which triggered this code:

         (if (consp parent)
             (apply #'nconc
                    (mapcar (lambda (parent)
                              (cons parent
                                    (or (get parent 'error-conditions)
                                        (error "Unknown signal `%s'" parent))))

(get parent 'error-conditions) may return a constant list, so I just
changed the `nconc' to `append'.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#19786: 25.0.50; broken build (Attempt to modify RO object)

[Stefan Monnier]

> (get parent 'error-conditions) may return a constant list, so I just
> changed the `nconc' to `append'.

Thanks.  Even if the list is not read-only, using nconc is an error.


        Stefan