From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Vibhav Pant <vibhavp@gmail.com>
Subject: Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char.
Date: Wed, 18 Mar 2015 23:18:04 -0400 [thread overview]
Message-ID: <jwvegol8yvv.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YYJvB-0001qD-9d@vcs.savannah.gnu.org> (Vibhav Pant's message of "Wed, 18 Mar 2015 19:46:29 +0000")
> * lisp/leim/quail/hangul.el
> * lisp/progmodes/cperl-mode.el: Use delete-char instead of
> delete-backward-char, fixes compilation warnings.
The above doesn't use the right syntax. The right syntax looks like
* <filename> (<functionname>): blabla.
IOW you need to add the function names.
Please re-read https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
> @@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is non-nil."
> (delete-region (point) p))
> (if cperl-electric-backspace-untabify
> (backward-delete-char-untabify arg)
> - (delete-backward-char arg)))))
> + (delete-char (- arg))))))
This doesn't look right: I think here we do want to run
delete-backward-char since this is part of a command which basically
extends the normal binding of DEL which is delete-backward-char.
Maybe we should call it interactively, tho.
Stefan
next parent reply other threads:[~2015-03-19 3:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150318194629.7043.70347@vcs.savannah.gnu.org>
[not found] ` <E1YYJvB-0001qD-9d@vcs.savannah.gnu.org>
2015-03-19 3:18 ` Stefan Monnier [this message]
2015-03-19 3:58 ` [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char John Wiegley
2015-03-19 7:25 ` ChangeLogs Ivan Shmakov
2015-03-19 21:39 ` ChangeLogs Paul Eggert
2015-03-19 4:59 ` [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char Vibhav Pant
2015-03-19 18:48 ` vibhavp
2015-03-19 20:04 ` Stefan Monnier
2015-03-19 20:21 ` vibhavp
2015-03-19 20:57 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvegol8yvv.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.