From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20152: 24.4: bookmarks display wrong annotation (FIX INCLUDED) Date: Wed, 25 Mar 2015 21:41:30 -0400 Message-ID: References: <550BF8BE.5080105@gmx.com> <550C67C2.9020208@gmx.com> <550C6B09.3010208@gmx.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427334141 13064 80.91.229.3 (26 Mar 2015 01:42:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Mar 2015 01:42:21 +0000 (UTC) Cc: 20152@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 26 02:42:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YawoE-0002ID-T5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Mar 2015 02:42:11 +0100 Original-Received: from localhost ([::1]:42214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YawoE-0000P6-0a for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Mar 2015 21:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YawoA-0000Ot-FY for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2015 21:42:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yawo7-0008Qo-3P for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2015 21:42:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yawo7-0008Qd-0G for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2015 21:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yawo6-00087c-FT for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2015 21:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Mar 2015 01:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20152 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20152-submit@debbugs.gnu.org id=B20152.142733410231195 (code B ref 20152); Thu, 26 Mar 2015 01:42:02 +0000 Original-Received: (at 20152) by debbugs.gnu.org; 26 Mar 2015 01:41:42 +0000 Original-Received: from localhost ([127.0.0.1]:36756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yawnm-000873-5F for submit@debbugs.gnu.org; Wed, 25 Mar 2015 21:41:42 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:16516) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yawnh-00086k-97 for 20152@debbugs.gnu.org; Wed, 25 Mar 2015 21:41:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCws0EhQYDSSIE6IRi3QYWAwDgz4Dg3AEqDs X-IPAS-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCws0EhQYDSSIE6IRi3QYWAwDgz4Dg3AEqDs X-IronPort-AV: E=Sophos;i="5.01,1,1400040000"; d="scan'208";a="114595128" Original-Received: from 65-110-216-75.cpe.pppoe.ca (HELO pastel.home) ([65.110.216.75]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Mar 2015 21:41:32 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DDEA82455; Wed, 25 Mar 2015 21:41:30 -0400 (EDT) In-Reply-To: <550C6B09.3010208@gmx.com> (Boruch Baum's message of "Fri, 20 Mar 2015 14:46:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100938 Archived-At: > In the bookmark list buffer, after viewing an annotation for a > bookmark, navigating to another bookmark entry does not kill the > annotation buffer display, leading to confusion about which entry > the still-visible annotation refers. Indeed. How 'bout we only fix this part, not by removing the window, but by keeping it up-to-date as long as the annotations buffer is displayed? Can you provide a patch which does just that? > +(defvar bookmark-bmenu-toggle-auto-display-annotations nil I think this is not needed: if the user wants to see the annotations, she can hit `a' after which they'll be auto-updated as she moves in the list. And if she doesn't want to see the annotations, she can hit `q' in the annotations buffer (which should call quit-window). > +"When not `nil', function `bookmark-bmenu-show-annotation' (by > +default, bound to `a`), toggles whether to automatically display > +a bookmark's annotation as one navigates through the bookmark > +list. Default is `nil'.") We typically use "non-nil" and "nil" rather than "not `nil'" and "`nil'". Same for t which we don't put in `...'. All other symbols indeed do get `...'. > + (if bookmark-bmenu-auto-display-annotations > + (setq bookmark-bmenu-auto-display-annotations nil) > + (setq bookmark-bmenu-auto-display-annotations t))) Aka (setq bookmark-bmenu-auto-display-annotations (not bookmark-bmenu-auto-display-annotations)) > +(defvar bookmark-bmenu-auto-display-annotations nil I don't think we need this either, just use (get-buffer-window "*Bookmark Annotation*" t) instead. > +(defun bookmark-bmenu-post-command-hook-function () > + (add-hook 'post-command-hook 'bookmark-bmenu-motion-hook-function t t)) > + > +(add-hook 'bookmark-bmenu-mode-hook 'bookmark-bmenu-post-command-hook-function) Better keep bookmark-bmenu-mode-hook nil by default. IOW, the code should simply be added to bookmark-bmenu-mode instead. Stefan