all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* commit-msg hook
@ 2015-04-10 10:43 Eli Zaretskii
  2015-04-10 18:23 ` Johan Bockgård
  2015-04-11  2:42 ` Paul Eggert
  0 siblings, 2 replies; 27+ messages in thread
From: Eli Zaretskii @ 2015-04-10 10:43 UTC (permalink / raw)
  To: Paul Eggert; +Cc: emacs-devel

On MS-Windows, this hook fails commits with valid UTF-8 characters in
the log messages, probably because the version of Gawk I have here is
too old (3.0.4; that's what MSYS comes with).

The mawk 1.3.3 replacement regexp for non_print does work, so I
suggest to have a Gawk version check in the script, and use the
replacement for older Gawk's.

Btw, when the hook is run by Git, the "; see 'CONTRIBUTE'" part of the
message is not shown; could it be that the semi-colon gets interpreted
by the shell, or something like that?  (My Git version is 1.9.5.)

I would also suggest to say explicitly in the message that the commit
was aborted, because it is not at all clear, at least to the
uninitiated.  It wasn't until I did a "git show" that the fact the
commit was aborted became apparent to me.

Thanks.



^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2015-04-14 18:59 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10 10:43 commit-msg hook Eli Zaretskii
2015-04-10 18:23 ` Johan Bockgård
2015-04-11  2:42 ` Paul Eggert
2015-04-11  7:24   ` Eli Zaretskii
2015-04-11  9:55     ` Eli Zaretskii
2015-04-11  9:59       ` Eli Zaretskii
2015-04-11 12:42         ` Dmitry Gutov
2015-04-11 14:29           ` Eli Zaretskii
2015-04-11 15:13             ` Dmitry Gutov
2015-04-11 15:17               ` Eli Zaretskii
2015-04-12  3:36                 ` Stefan Monnier
2015-04-12 18:54                   ` chad
2015-04-11 15:40       ` Paul Eggert
2015-04-11 16:40         ` Eli Zaretskii
2015-04-11 20:09           ` Paul Eggert
2015-04-12 16:10             ` Eli Zaretskii
2015-04-13 15:48             ` Eli Zaretskii
2015-04-13 18:37               ` Paul Eggert
2015-04-13 20:18                 ` Eli Zaretskii
2015-04-13 21:19                   ` Paul Eggert
2015-04-14 15:08                     ` Eli Zaretskii
2015-04-14 17:01                       ` Paul Eggert
2015-04-14 17:09                         ` Eli Zaretskii
2015-04-14 17:42                           ` Paul Eggert
2015-04-14 18:01                             ` Eli Zaretskii
2015-04-14 18:32                               ` Paul Eggert
2015-04-14 18:59                                 ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.