From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21747: 25.0.50; while-no-input breaks kbd event handling when called from post-command-hook Date: Sun, 25 Oct 2015 16:10:26 -0400 Message-ID: References: <87bnboemqb.fsf@gnu.org> <838u6sy9s1.fsf@gnu.org> <877fmcejgn.fsf@gnu.org> <83ziz8wrun.fsf@gnu.org> <8737x0egvm.fsf@gnu.org> <83vb9wwnc6.fsf@gnu.org> <874mhg1n25.fsf@gnu.org> <83si50wi2m.fsf@gnu.org> <87fv109yxo.fsf@gnu.org> <83lhasweeh.fsf@gnu.org> <87si4zpg97.fsf@gnu.org> <87oafnpdvh.fsf@gnu.org> <87k2qbpafd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445803884 32326 80.91.229.3 (25 Oct 2015 20:11:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Oct 2015 20:11:24 +0000 (UTC) Cc: bruce.connor.am@gmail.com, 21747@debbugs.gnu.org, storm@cua.dk To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 25 21:11:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZqRdI-0000nO-ED for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Oct 2015 21:11:12 +0100 Original-Received: from localhost ([::1]:49375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqRdH-0007qP-M4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Oct 2015 16:11:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqRdE-0007qH-9c for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2015 16:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqRd9-0000Np-9T for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2015 16:11:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqRd8-0000Ni-Sp for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2015 16:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZqRd8-0003eM-E0 for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2015 16:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Oct 2015 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21747-submit@debbugs.gnu.org id=B21747.144580383213995 (code B ref 21747); Sun, 25 Oct 2015 20:11:02 +0000 Original-Received: (at 21747) by debbugs.gnu.org; 25 Oct 2015 20:10:32 +0000 Original-Received: from localhost ([127.0.0.1]:38231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqRce-0003de-8J for submit@debbugs.gnu.org; Sun, 25 Oct 2015 16:10:32 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:55441) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqRcc-0003dW-0Q for 21747@debbugs.gnu.org; Sun, 25 Oct 2015 16:10:30 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t9PKAQik020484; Sun, 25 Oct 2015 16:10:27 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 7F490660C7; Sun, 25 Oct 2015 16:10:26 -0400 (EDT) In-Reply-To: <87k2qbpafd.fsf@gnu.org> (Tassilo Horn's message of "Sun, 25 Oct 2015 10:25:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5470=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5470> : inlines <3953> : streams <1527328> : uri <2070190> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108030 Archived-At: > But I'm really not sure if that's the right thing to do. Maybe it's > better to fix sh-smie-sh-forward-token so that it doesn't return ";" > when actually no movement did occur because we already started out at > EOB. That would be this: Sounds right. > - (let ((semi (sh-smie--newline-semi-p))) > - (forward-line 1) > - (if (or semi (eobp)) ";" > - (sh-smie-sh-forward-token)))) > + (unless (eobp) > + (let ((semi (sh-smie--newline-semi-p))) > + (forward-line 1) > + (if (or semi (eobp)) ";" > + (sh-smie-sh-forward-token))))) Another option might be to fix sh-smie--newline-semi-p so it returns nil when at EOB. I haven't looked at the code recently, so I can't remember if that would be better or not. Stefan