From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] comment-cache 223d16f 2/3: Apply `comment-depth' text properties when calling `back_comment'. Date: Fri, 11 Mar 2016 22:28:27 -0500 Message-ID: References: <20160308132530.861.91488@vcs.savannah.gnu.org> <20160308183010.GB6269@acm.fritz.box> <20160309174816.GE3948@acm.fritz.box> <20160310222400.GE4831@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457753332 27913 80.91.229.3 (12 Mar 2016 03:28:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2016 03:28:52 +0000 (UTC) Cc: Alan Mackenzie , emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 04:28:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aeaEK-0007kN-W4 for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2016 04:28:41 +0100 Original-Received: from localhost ([::1]:58783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeaEH-0003Av-3u for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2016 22:28:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeaED-0003An-EA for emacs-devel@gnu.org; Fri, 11 Mar 2016 22:28:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeaE9-0002xI-E0 for emacs-devel@gnu.org; Fri, 11 Mar 2016 22:28:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:25379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeaE9-0002vN-AJ; Fri, 11 Mar 2016 22:28:29 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CVDQA731xV/8KhxEVcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIxALDiYHCxQYDSSINwjPIwEBAQcBAQEBAR2LOoQsWQeELQWMMJ5LiESBRSOBZlWBWyCBNIFEAQEB X-IPAS-Result: A0CVDQA731xV/8KhxEVcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIxALDiYHCxQYDSSINwjPIwEBAQcBAQEBAR2LOoQsWQeELQWMMJ5LiESBRSOBZlWBWyCBNIFEAQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="196006437" Original-Received: from 69-196-161-194.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.196.161.194]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Mar 2016 22:28:27 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 35999AE323; Fri, 11 Mar 2016 22:28:27 -0500 (EST) In-Reply-To: (Richard Stallman's message of "Fri, 11 Mar 2016 20:53:19 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201518 Archived-At: >> They would do the same as they currently do - except where an >> inadvertant paren in C0 currently prevents the correct behaviour. > In objective terms, which cases are those? > Basically, I'm asking for a complete statement of the change > in behavior you propose. With that, we could see all of its > consequences, the good ones and the bad ones. Richard. His changes's impacts are extremely minor. More specifically the changes are limited as follows: - only recognizing and skipping comments is affected. - only when moving backward. - only when there's an open-paren-in-column-0. - only when that open paren is inside a string or a comment. I can't imagine a single case where the change wouldn't be considered a clear bugfix. It does have also performance consequences (hopefully by eliminating some pathological cases, without unduly slowing down the common case), of course, but I don't think that's what you were worried about. Stefan