From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block Date: Fri, 03 Jun 2016 13:00:03 -0400 Message-ID: References: <87lh2vo7s6.fsf@gmail.com> <87shx23830.fsf@gmail.com> <87wpmcwn13.fsf@russet.org.uk> <87wpm9q4z7.fsf@russet.org.uk> <87vb1rbbg1.fsf@russet.org.uk> <87shwutfmo.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1464973911 12931 80.91.229.3 (3 Jun 2016 17:11:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Jun 2016 17:11:51 +0000 (UTC) Cc: Chong Yidong , 23632@debbugs.gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 03 19:11:39 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b8sTE-0004hF-Qh for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jun 2016 19:01:16 +0200 Original-Received: from localhost ([::1]:56744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8sTD-0006W1-Tb for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jun 2016 13:01:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8sT3-0006TE-3h for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2016 13:01:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8sSz-0002uf-Vl for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2016 13:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8sSz-0002ub-Sq for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2016 13:01:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b8sSz-0002PF-NK for bug-gnu-emacs@gnu.org; Fri, 03 Jun 2016 13:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jun 2016 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23632-submit@debbugs.gnu.org id=B23632.14649732089182 (code B ref 23632); Fri, 03 Jun 2016 17:01:01 +0000 Original-Received: (at 23632) by debbugs.gnu.org; 3 Jun 2016 17:00:08 +0000 Original-Received: from localhost ([127.0.0.1]:53440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8sS8-0002O2-Ig for submit@debbugs.gnu.org; Fri, 03 Jun 2016 13:00:08 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:51710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8sS7-0002Nt-1H for 23632@debbugs.gnu.org; Fri, 03 Jun 2016 13:00:07 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u53H04t5003820; Fri, 3 Jun 2016 13:00:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 00C5160164; Fri, 3 Jun 2016 13:00:03 -0400 (EDT) In-Reply-To: <87shwutfmo.fsf@russet.org.uk> (Phillip Lord's message of "Fri, 03 Jun 2016 17:13:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5692=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5692> : inlines <4902> : streams <1646025> : uri <2223125> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119016 Archived-At: > Simple let binding would not give quite the same functionality, because > of the last part -- I also add a boundary to buffers with a greater > recursive depth; with a let binding, I think these would be unbound for > commands that lower the recursion depth. Ah, you mean that the value of undo-auto--undoably-changed-buffers needs to be propagated "out" when we leave the let-binding. You're right. So instead of a simple `let', it needs to be something like: (let ((tmp ())) (unwind-protect (let ((undo-auto--undoably-changed-buffers nil)) (unwind-protect (setq tmp undo-auto--undoably-changed-buffers))) (setq undo-auto--undoably-changed-buffers (append tmp undo-auto--undoably-changed-buffers)))) Or (let ((tmp undo-auto--undoably-changed-buffers)) (unwind-protect (progn (setq undo-auto--undoably-changed-buffers nil) ) (setq undo-auto--undoably-changed-buffers (append undo-auto--undoably-changed-buffers tmp)))) Maybe a simple alternative would be to do (let ((undo-auto--undoably-changed-buffers nil)) (unwind-protect (undo-auto--ensure-boundary undo-auto--undoably-changed-buffers))) -- Stefan