From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: User-defined record types, v2 Date: Sat, 18 Mar 2017 18:24:34 -0400 Message-ID: References: <86y3w2tt2n.fsf@molnjunk.nocrew.org> <86tw6qtt01.fsf@molnjunk.nocrew.org> <86k27mtsnv.fsf@molnjunk.nocrew.org> <86fuiatsh3.fsf@molnjunk.nocrew.org> <86bmsyts9f.fsf@molnjunk.nocrew.org> <8337eaxzc3.fsf@gnu.org> <8637eatm6f.fsf@molnjunk.nocrew.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489875901 25095 195.159.176.226 (18 Mar 2017 22:25:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 22:25:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 18 23:24:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpMmJ-0005UV-ST for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 23:24:52 +0100 Original-Received: from localhost ([::1]:54845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpMmP-0005y7-Vb for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 18:24:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpMmJ-0005xp-AG for emacs-devel@gnu.org; Sat, 18 Mar 2017 18:24:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpMmG-0001XY-5S for emacs-devel@gnu.org; Sat, 18 Mar 2017 18:24:51 -0400 Original-Received: from [195.159.176.226] (port=34927 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpMmF-0001Wr-Th for emacs-devel@gnu.org; Sat, 18 Mar 2017 18:24:48 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cpMm4-0003qb-73 for emacs-devel@gnu.org; Sat, 18 Mar 2017 23:24:36 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:IsACMp6BRTxQPwwbJiG5JYxFw3A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213141 Archived-At: >>> +INLINE void >>> +CHECK_RECORD_TYPE (Lisp_Object x) >>> +{ >>> + /* CHECK_SYMBOL (x); */ >>> +} >> >> ??? > This is still a work in progress. I initially added this function to > check everywhere that the first slot is a valid defstruct type name. > But then Stefan Monnier added support for EIEIO instances and made the > first slot be a class object. Right. Currently the TYPE should be either a symbol (i.e. a "type name"), or a `record` (a "type descriptor" aka "class") whose first field (i.e. (aref type 1)) is a symbol. But I'm not even sure we should enforce this in the `record` and `make-record` primitives. After all, it's not needed for safety. And since we allow (aset 0 ) we can circumvent this check anyway. Stefan PS: Of the two possible TYPEs, the `symbol' case is the least efficient, so it'd be good to get rid of it, but the `record` case has an obvious bootstrap problem if we force the TYPE to be a `record`.