From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Something weird with when-let*/if-let* Date: Sat, 14 Oct 2017 16:42:24 -0400 Message-ID: References: <877evy2am9.fsf@ericabrahamsen.net> <87shel27rc.fsf@ericabrahamsen.net> <87efq51r12.fsf@ericabrahamsen.net> <8760bh1oqj.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508013825 2507 195.159.176.226 (14 Oct 2017 20:43:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 20:43:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 14 22:43:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3THM-0006lA-2H for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2017 22:43:28 +0200 Original-Received: from localhost ([::1]:55135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3THT-00033L-Hc for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2017 16:43:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3TGq-00033G-Gs for emacs-devel@gnu.org; Sat, 14 Oct 2017 16:42:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3TGn-00043H-EW for emacs-devel@gnu.org; Sat, 14 Oct 2017 16:42:56 -0400 Original-Received: from [195.159.176.226] (port=55368 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3TGn-00042j-72 for emacs-devel@gnu.org; Sat, 14 Oct 2017 16:42:53 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e3TGT-0008Ub-5A for emacs-devel@gnu.org; Sat, 14 Oct 2017 22:42:33 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 14 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:CJmXU+yHG/7ayTqyjJsp7gW27wU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219531 Archived-At: > Besides message.el, nnimap.el is the only gnus lib to use when-let*. > I can just add another subr-x require in nnimap for now -- if it starts That's indeed what should be done, regardless of what message.el does: if a foo.el uses a macro defined in bar.el, it should generally require that bar.el directly rather than rely on some toto.el file to load it. I'm not saying that we follow this rule all the time, but in my experience, this is a sane rule to follow. The downside is really negligible: if foo.el requires foo.el which also requires bar.el, the extra/redundant (require 'bar) will cost very little anyway. Stefan