From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Alan Mackenzie <acm@muc.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
ccsmile2008@outlook.com, npostavs@gmail.com, emacs-devel@gnu.org
Subject: Re: beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode]
Date: Sat, 30 Dec 2017 23:26:24 -0500 [thread overview]
Message-ID: <jwvefnbbk3s.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20171230154305.GF10623@ACM> (Alan Mackenzie's message of "Sat, 30 Dec 2017 15:43:05 +0000")
> + (if (nth 3 ppss) ; in a string
> + start
> + (when (nth 4 ppss) ; in a comment
> + (setq ppss
> + (parse-partial-sexp (point) eol nil nil ppss 'syntax-table)))
> + (catch 'got-it
> + (while (< (point) eol)
> + (setq start (point))
> + (setq ppss (parse-partial-sexp (point) eol nil nil ppss t))
> + (setq end (if (nth 4 ppss) (nth 8 ppss) eol))
> + (goto-char start)
> + (skip-syntax-forward "-" end)
> + (when (< (point) end)
> + (throw 'got-it (point)))
> + (unless (forward-comment 1) ; comment straddles line break.
> + (throw 'got-it nil))
> + (setq ppss (syntax-ppss))))))))
Why not use something like
(>= (forward-comment (point-max)) (line-end-position))
?
Stefan
next prev parent reply other threads:[~2017-12-31 4:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 9:49 26.0.90: mark-defun problem in c-mode zhang cc
2017-12-30 10:30 ` Eli Zaretskii
2017-12-30 10:34 ` Alan Mackenzie
2017-12-30 12:01 ` beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode] Alan Mackenzie
2017-12-30 12:53 ` Eli Zaretskii
2017-12-30 13:05 ` Alan Mackenzie
2018-01-03 4:51 ` Marcin Borkowski
2018-01-03 16:24 ` Alan Mackenzie
2018-01-05 14:55 ` zhang cc
2018-01-06 12:00 ` Alan Mackenzie
2018-01-06 13:54 ` zhang cc
2018-01-07 6:25 ` Marcin Borkowski
2018-03-26 6:57 ` Marcin Borkowski
2017-12-30 15:43 ` Alan Mackenzie
2017-12-30 18:43 ` Stephen Leake
2017-12-31 10:55 ` Alan Mackenzie
2017-12-31 4:26 ` Stefan Monnier [this message]
2017-12-31 10:50 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvefnbbk3s.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=ccsmile2008@outlook.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.