From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5f72004: Revert "Fix command repetition with lexical-binding (Bug#29334)" Date: Sun, 07 Jan 2018 10:36:54 -0500 Message-ID: References: <20180107024858.4583.97855@vcs0.savannah.gnu.org> <20180107024859.76DAA2020F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515339342 8199 195.159.176.226 (7 Jan 2018 15:35:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Jan 2018 15:35:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Noam Postavsky To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 07 16:35:38 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYCyz-0001bb-GV for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 16:35:33 +0100 Original-Received: from localhost ([::1]:56691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYD0y-0000CR-GU for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 10:37:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYD0N-0000AH-3y for emacs-devel@gnu.org; Sun, 07 Jan 2018 10:36:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYD0J-0006Pr-6V for emacs-devel@gnu.org; Sun, 07 Jan 2018 10:36:59 -0500 Original-Received: from pmta21.teksavvy.com ([76.10.157.36]:18909) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYD0J-0006PK-18 for emacs-devel@gnu.org; Sun, 07 Jan 2018 10:36:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GDZQDEPVJa/yyKSC1cHQEBBQELAYM/g?= =?us-ascii?q?VqOQ45xm0EdhSgChDJCFQEBAQEBAQEBAQNoKIUlBnkQCw0nEhQYinW0DiECig0?= =?us-ascii?q?BAQEHAgElhjWDP4MuhWqFMAWTOZAllzyKECiHUxOYQDUkgVAyGggwgmiDCIFsI?= =?us-ascii?q?4pOAQEB?= X-IPAS-Result: =?us-ascii?q?A2GDZQDEPVJa/yyKSC1cHQEBBQELAYM/gVqOQ45xm0EdhSg?= =?us-ascii?q?ChDJCFQEBAQEBAQEBAQNoKIUlBnkQCw0nEhQYinW0DiECig0BAQEHAgElhjWDP?= =?us-ascii?q?4MuhWqFMAWTOZAllzyKECiHUxOYQDUkgVAyGggwgmiDCIFsI4pOAQEB?= X-IronPort-AV: E=Sophos;i="5.46,326,1511845200"; d="scan'208";a="17034510" Original-Received: from unknown (HELO pastel.home) ([45.72.138.44]) by smtp.teksavvy.com with ESMTP; 07 Jan 2018 10:36:54 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 0CF0D6049F; Sun, 7 Jan 2018 10:36:54 -0500 (EST) In-Reply-To: <20180107024859.76DAA2020F@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Sat, 6 Jan 2018 21:48:59 -0500 (EST)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221668 Archived-At: > --- a/src/callint.c > +++ b/src/callint.c > @@ -357,9 +357,7 @@ invoke it. If KEYS is omitted or nil, the return value of > /* Compute the arg values using the user's expression. */ > specs = Feval (specs, > CONSP (funval) && EQ (Qclosure, XCAR (funval)) > - ? CAR_SAFE (XCDR (funval)) > - : COMPILEDP (funval) && INTEGERP (AREF (funval, COMPILED_ARGLIST)) > - ? Qt : Qnil); > + ? CAR_SAFE (XCDR (funval)) : Qnil); > if (events != num_input_events || !NILP (record_flag)) > { > /* We should record this command on the command history. */ Why? This looks wrong. Stefan