From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Noam Postavsky <npostavs@gmail.com>
Subject: Re: [Emacs-diffs] master 5f72004: Revert "Fix command repetition with lexical-binding (Bug#29334)"
Date: Sun, 07 Jan 2018 10:36:54 -0500 [thread overview]
Message-ID: <jwvefn1zno1.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20180107024859.76DAA2020F@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Sat, 6 Jan 2018 21:48:59 -0500 (EST)")
> --- a/src/callint.c
> +++ b/src/callint.c
> @@ -357,9 +357,7 @@ invoke it. If KEYS is omitted or nil, the return value of
> /* Compute the arg values using the user's expression. */
> specs = Feval (specs,
> CONSP (funval) && EQ (Qclosure, XCAR (funval))
> - ? CAR_SAFE (XCDR (funval))
> - : COMPILEDP (funval) && INTEGERP (AREF (funval, COMPILED_ARGLIST))
> - ? Qt : Qnil);
> + ? CAR_SAFE (XCDR (funval)) : Qnil);
> if (events != num_input_events || !NILP (record_flag))
> {
> /* We should record this command on the command history. */
Why? This looks wrong.
Stefan
next parent reply other threads:[~2018-01-07 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180107024858.4583.97855@vcs0.savannah.gnu.org>
[not found] ` <20180107024859.76DAA2020F@vcs0.savannah.gnu.org>
2018-01-07 15:36 ` Stefan Monnier [this message]
2018-01-09 2:32 ` [Emacs-diffs] master 5f72004: Revert "Fix command repetition with lexical-binding (Bug#29334)" Noam Postavsky
2018-01-09 13:11 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvefn1zno1.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.