From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#31118: 27.0.50; Can't load/compile websocket in 32bit master Date: Tue, 17 Apr 2018 08:18:40 -0400 Message-ID: References: <6deb652e-7bd1-f003-ac84-0f4c6a18de99@cs.ucla.edu> <80fbbf82-c20f-6a01-b257-45caa4a87fdf@cs.ucla.edu> <100a3631-afa6-ef69-5fa1-6ae95df20c35@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523967439 21653 195.159.176.226 (17 Apr 2018 12:17:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Apr 2018 12:17:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31118@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 17 14:17:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8PXq-0005Ru-Ov for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 14:17:10 +0200 Original-Received: from localhost ([::1]:35131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8PZx-00034c-6f for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 08:19:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8PZi-00032U-PP for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 08:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8PZe-0005fs-Pc for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 08:19:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48923) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8PZe-0005fc-LK for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 08:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8PZe-0006Ot-CZ for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 08:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Apr 2018 12:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31118-submit@debbugs.gnu.org id=B31118.152396753424588 (code B ref 31118); Tue, 17 Apr 2018 12:19:02 +0000 Original-Received: (at 31118) by debbugs.gnu.org; 17 Apr 2018 12:18:54 +0000 Original-Received: from localhost ([127.0.0.1]:56820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8PZW-0006OW-KY for submit@debbugs.gnu.org; Tue, 17 Apr 2018 08:18:54 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:55924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8PZU-0006OO-O3 for 31118@debbugs.gnu.org; Tue, 17 Apr 2018 08:18:53 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w3HCIjPh014902; Tue, 17 Apr 2018 08:18:46 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C92BB6A197; Tue, 17 Apr 2018 08:18:40 -0400 (EDT) In-Reply-To: <100a3631-afa6-ef69-5fa1-6ae95df20c35@cs.ucla.edu> (Paul Eggert's message of "Tue, 17 Apr 2018 00:50:57 -0700") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6266=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6266> : inlines <6565> : streams <1784285> : uri <2627011> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145482 Archived-At: > Do you mean 'read' should call 'display-warning' for now? I suppose we could > make read-integer-overflow-as-float be a three-state variable: either (1) > signal an error, or (2) call display-warning and yield a float, or (3) > silently yield a float, and have (2) be the default for now. However, > I worry that (2) might lead to further problems, e.g., display-warning is > Lisp code that might in turn call 'read' and loop recursively. We already solved this problem for old-style backquotes: don't emit the warning directly, instead set a variable and let the caller check the value of the variable to emit a warning if needed. > The code we're talking about had nonportable code like (eq desktop > #xffffffff) that doesn't work on platforms with 30-bit fixnums anyway. I don't disagree with your change. But the problems encountered with code in GNU ELPA makes me think that we want to do it in two steps to reduce the backward compatibility pain. > Admittedly --with-wide-hit is a ~30% CPU performance hit on my circa-2010 > AMD desktop. 4 out of 5 of my machines predate your AMD desktop, and I use a 32bit build on them. > If defaulting to --with-wide-int is too drastic, I hope that the > already-existing read-integer-overflow-as-float flag is enough > backstop for people who want to run nonportable code on platforms with > 30-bit fixnums. If we want to signal an error by default, then I think it's important for this error to give clear steps to set read-integer-overflow-as-float (and in a message that's not too prone to disappear before the user gets to see and act on it). Stefan