From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package proposal: visual-path-abbrev.el Date: Fri, 08 Mar 2019 17:18:54 -0500 Message-ID: References: <87tvglpmcx.fsf@gnu.org> <83k1hhh5mb.fsf@gnu.org> <874l8k47fi.fsf@gnu.org> <83imx0f0x0.fsf@gnu.org> <87k1hg6jl3.fsf@gnu.org> <83h8ciecub.fsf@gnu.org> <8736o1iqsf.fsf@gnu.org> <87zhq51n1q.fsf@gnu.org> <875zstz2wc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240320"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 08 23:19:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2Npe-0010NM-OL for ged-emacs-devel@m.gmane.org; Fri, 08 Mar 2019 23:19:10 +0100 Original-Received: from localhost ([127.0.0.1]:50569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Npd-0003yA-M7 for ged-emacs-devel@m.gmane.org; Fri, 08 Mar 2019 17:19:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2NpS-0003xE-SF for emacs-devel@gnu.org; Fri, 08 Mar 2019 17:18:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2NpR-0008RW-AT for emacs-devel@gnu.org; Fri, 08 Mar 2019 17:18:58 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2NpR-0008Qb-41 for emacs-devel@gnu.org; Fri, 08 Mar 2019 17:18:57 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x28MIsE5025072; Fri, 8 Mar 2019 17:18:55 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 5FBCB6A542; Fri, 8 Mar 2019 17:18:54 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Fri, 08 Mar 2019 14:01:56 -0500") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6499=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6499> : inlines <7030> : streams <1815147> : uri <2809209> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233940 Archived-At: > Haven't tried it yet, but it sounds like maybe it's just a plain bug in > cursor-sensor. Indeed, it seems the patch below fixes it (IOW, the problem was that the code handled text-properties correctly but not overlay properties). Stefan diff --git a/lisp/emacs-lisp/cursor-sensor.el b/lisp/emacs-lisp/cursor-sensor.el index a21d78998a..66b940f7fb 100644 --- a/lisp/emacs-lisp/cursor-sensor.el +++ b/lisp/emacs-lisp/cursor-sensor.el @@ -160,7 +160,7 @@ cursor-sensor--detect (setcdr old nil)) (if (or (and (null new) (null (cdr old))) (and (eq new (cdr old)) - (eq (next-single-property-change + (eq (next-single-char-property-change start 'cursor-sensor-functions nil end) end))) ;; Clearly nothing to do. @@ -172,7 +172,7 @@ cursor-sensor--detect (let ((pos start) (missing nil)) (while (< pos end) - (setq pos (next-single-property-change + (setq pos (next-single-char-property-change pos 'cursor-sensor-functions nil end)) (unless (memq f (get-char-property