From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals
Date: Tue, 23 Jul 2019 15:57:12 -0400 [thread overview]
Message-ID: <jwvef2gttqr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20190723171715.8F064210EC@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 23 Jul 2019 13:17:15 -0400 (EDT)")
> The usual purpose of the terminal-specific library is to map the
> escape sequences used by the terminal's function keys onto more
> meaningful names, using @code{input-decode-map} (or
> -@code{function-key-map} before it). See the file
> +@code{local-function-key-map} before it).
Actually, they should mostly use `input-decode-map` instead nowadays (the
difference is that `input-decode-map`'s remapping is applied
unconditionally, where `(local-)function-key-map`'s remapping is only
applied when there's no normal keybinding).
> @smallexample
> ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.}
> -(define-key function-key-map [kp-enter] [?\C-j])
> +(define-key local-function-key-map [kp-enter] [?\C-j])
This remapping should probably be applied to any terminal that has
a kp-enter key, so I think the change is for the worse.
> @@ -190,7 +190,7 @@ key sequence, providing the @acronym{ASCII} key sequence prefix is
> already known by Emacs to be a prefix. As a result of providing this
> support, some terminal/keyboard/window system configurations, which
> don't have a complete set of sensible function key bindings built into
> -Emacs in @code{function-key-map}, can still be configured for use with
> +Emacs in @code{local-function-key-map}, can still be configured for use with
This one should also refer to `input-decode-map`.
> -(define-key function-key-map [M-@key{TAB}] [?\M-\t])
> +(define-key local-function-key-map [M-@key{TAB}] [?\M-\t])
[...]
> -(define-key function-key-map [f11] [?\e])
> +(define-key local-function-key-map [f11] [?\e])
As above, I think these changes are for the worse.
Stefan
next parent reply other threads:[~2019-07-23 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190723171714.15080.69466@vcs0.savannah.gnu.org>
[not found] ` <20190723171715.8F064210EC@vcs0.savannah.gnu.org>
2019-07-23 19:57 ` Stefan Monnier [this message]
2019-07-24 12:41 ` [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals Lars Ingebrigtsen
2019-07-24 13:52 ` Stefan Monnier
2019-07-25 9:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvef2gttqr.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.