From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Dedicated window for *log-edit-files* Date: Sat, 26 Oct 2019 08:00:25 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101611"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , emacs-devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 26 14:01:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOKkl-000QFh-RC for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 14:01:08 +0200 Original-Received: from localhost ([::1]:39836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOKkk-0006md-6I for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 08:01:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36776) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOKkD-0006lt-3T for emacs-devel@gnu.org; Sat, 26 Oct 2019 08:00:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOKkB-00008g-PW for emacs-devel@gnu.org; Sat, 26 Oct 2019 08:00:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27227) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iOKkB-00008R-J9 for emacs-devel@gnu.org; Sat, 26 Oct 2019 08:00:31 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7694881119; Sat, 26 Oct 2019 08:00:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F015A80D78; Sat, 26 Oct 2019 08:00:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572091228; bh=dQGk10/9pdQ409GOPy6NlLvv+m6MzPi0Llq4aqAuHV4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=azkYtODT4BE4imyxIrwpU7wXOXqg1BnZXcoXfk+KH8sGWj/0piWMx3/UiUeRYrOfZ DqeDNXNp/NMCk9xUppTbtJzKGu2OS0uNXm4gNCbFd1tNuQIxNgfbEjLnIWiPUHlJKU dQWjoFPvjtbYjgbUOqiZPM+PfFJZIroq6F4bE5fWCln/ZCjtS8uM2ZB8XJNMOQ1OjB zDT6Va8QABawBBYcOCgPGCxgqKMH+3zx3CvFxV7SeTsCzNxIzDgmwPo61g+AUcPC9/ vUDeNKnp/fE38swfwLtNLcBlE44mXQl1t2MWP6Yl3yofpMqhoBoMrqnaWqBD6BQedp pTchyH7l/7Bcw== Original-Received: from pastel (unknown [216.154.30.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9E2321202A4; Sat, 26 Oct 2019 08:00:27 -0400 (EDT) In-Reply-To: (martin rudalics's message of "Sat, 26 Oct 2019 10:12:16 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241442 Archived-At: > Probbaly, 'log-edit-show-files' should mark the window as dedicated > only if it appears on a separate frame. It should never appear on a separate frame, IIRC (that's the "-same-frame" part of cvs-pop-to-buffer-same-frame). > But the corresponding code is weird. For starters, wrapping some sort > of 'pop-to-buffer' in 'save-selected-window' is not reasonable IMHO. > And both, 'cvs-pop-to-buffer-same-frame' and 'cvs-bury-buffer', should > be eventually rewritten via 'display-buffer' such that "q" just quits > the associated window using its 'quit-restore' parameter. Quite so, Stefan