From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Dedicated window for *log-edit-files*
Date: Sat, 26 Oct 2019 08:00:25 -0400 [thread overview]
Message-ID: <jwveeyzen18.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <dcb82eed-52b6-2eea-482b-1762f1c23b6d@gmx.at> (martin rudalics's message of "Sat, 26 Oct 2019 10:12:16 +0200")
> Probbaly, 'log-edit-show-files' should mark the window as dedicated
> only if it appears on a separate frame.
It should never appear on a separate frame, IIRC (that's the
"-same-frame" part of cvs-pop-to-buffer-same-frame).
> But the corresponding code is weird. For starters, wrapping some sort
> of 'pop-to-buffer' in 'save-selected-window' is not reasonable IMHO.
> And both, 'cvs-pop-to-buffer-same-frame' and 'cvs-bury-buffer', should
> be eventually rewritten via 'display-buffer' such that "q" just quits
> the associated window using its 'quit-restore' parameter.
Quite so,
Stefan
next prev parent reply other threads:[~2019-10-26 12:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 11:48 Dedicated window for *log-edit-files* João Távora
2019-10-25 12:48 ` Stefan Monnier
2019-10-25 15:36 ` João Távora
2019-10-25 15:50 ` Stefan Monnier
2019-10-25 21:38 ` João Távora
2019-10-25 23:51 ` Stefan Monnier
2019-10-29 21:37 ` Juri Linkov
2019-10-25 14:43 ` Drew Adams
2019-10-25 15:21 ` João Távora
2019-10-26 8:12 ` martin rudalics
2019-10-26 12:00 ` Stefan Monnier [this message]
2019-10-27 7:49 ` martin rudalics
2019-10-27 17:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwveeyzen18.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.