From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode Date: Mon, 22 Jun 2020 16:03:31 -0400 Message-ID: References: <20200622191653.26453.39420@vcs0.savannah.gnu.org> <20200622191656.2D20920A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ted Zlatanov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 22 22:04:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnSfz-000G1d-K1 for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 22:04:19 +0200 Original-Received: from localhost ([::1]:56296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnSfy-0004s4-MW for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 16:04:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnSfI-0004SL-8T for emacs-devel@gnu.org; Mon, 22 Jun 2020 16:03:36 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnSfG-0005iv-DG for emacs-devel@gnu.org; Mon, 22 Jun 2020 16:03:35 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B249B44072F; Mon, 22 Jun 2020 16:03:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2AD62440712; Mon, 22 Jun 2020 16:03:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1592856212; bh=rRabVmpR/fMe5NoUsvypgJEpLkjKOw61PIKYyX8vNs0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Hf/wfyxZH+VfReGskbO3Bnnnti2sdcsylj2xRJ/f/LsimfWOqAiUSs+MpPYcVzxdo VWNdZWjycLJU6on8V0MeOjtZFhQerzAgb4MyKCyschb4d0z4EKJPlCgY0tePXDeE5s GXG1nIPaeGCfcVW8Wl0bVT3pfueTRAu/Ma62Yp+R4noul16VmYsVk4TTnetZFe/xSQ wXhf+axMzt0jyldRGkQXTfnaRunS7edoZVkOHc/E7H3GVpVKgnUqwmv8WN7VBk3712 iUJO7Yp9PBW482gMJAu4xHVszxSTuYgmufgBz/pwBZt4tyuCMW4l75Fp0GWu4f8FmK hlPRJm8t6vVzQ== Original-Received: from alfajor (unknown [108.175.228.207]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EAAA712029D; Mon, 22 Jun 2020 16:03:31 -0400 (EDT) In-Reply-To: <20200622191656.2D20920A26@vcs0.savannah.gnu.org> (Teodor Zlatanov's message of "Mon, 22 Jun 2020 15:16:56 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 14:56:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252517 Archived-At: > +(define-minor-mode auth-source-reveal-mode [...] > + (when auth-source-reveal-mode > + ;; Install the prettification magic. > + (prettify-symbols-add-prettification-rx > + 'auth-source-reveal-mode-prettify-regexp ; The identifier symbol. > + ;; regexp to hide/reveal > + (if (apply #'derived-mode-p auth-source-reveal-json-modes) > + (format "\"?password\"?[:[:blank:]]+\"\\([^\t\r\n\"]+\\)\"" auth-source-reveal-regex) > + (format "\\b%s\\b\\s-+\\([^ \t\r\n]+\\)" auth-source-reveal-regex)) > + auth-source-reveal-hider) > + > + (setq-local > + prettify-symbols-compose-predicate #'auth-source-reveal-compose-p) This erases any prior configuration of that variable, so it won't "play ball" with other users. > + (prettify-symbols-mode (if auth-source-reveal-mode 1 -1))) And here we forcefully enable/disable `prettify-symbols-mode` even if all the user wanted if to hide the passwords. I think we need to decouple the two user-level features. Stefan