From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 527413f: Go back to not using custom-push-theme when enabling a theme Date: Fri, 06 Nov 2020 11:47:58 -0500 Message-ID: References: <20201106123610.24601.8123@vcs0.savannah.gnu.org> <20201106123612.2172F20B2C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13575"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 17:49:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kb4v9-0003T6-Nl for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 17:49:03 +0100 Original-Received: from localhost ([::1]:53244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb4v8-0007qM-NP for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 11:49:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb4uC-0006ur-Ix for emacs-devel@gnu.org; Fri, 06 Nov 2020 11:48:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb4uA-0004wg-6N for emacs-devel@gnu.org; Fri, 06 Nov 2020 11:48:03 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C815C80B46; Fri, 6 Nov 2020 11:48:00 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 429098091C; Fri, 6 Nov 2020 11:47:59 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604681279; bh=Vpr/xIfKTACwSU6wCWrTadK/yxQKmHHFMqwrkzWDXu4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S0nBU4ah7CS7lkWeattN+nsFk0F9mBRGPrMjbs9gXiLlzaGU3e9+if8PiMYf9Vehl pZM3N7DJ6p2Ak2SFNRnJ0VCiCveI0/418nQrikoVet+Jm0P3a9u8OrcedbrpbHvqCE gcRz9xyOTYZ+9I0RQkofWAZPmiZzE1LfPsa3bv1yrml7uFsinxV3kEETxSmu3Xjr6h ho/SU9GllezR4Kp+geEU9OsRmckEbXFNDl7zrk8Z5L+7iK9t0qtqUPH2bgwr++gipA Aoi+BxfJXwmM9OqOKxnwtz3pt5F7sdcDbqPcfpmfX5Mr4uv5h79oYDP5cMPN1NOkc4 +fIxEukSjm+Vg== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0CBC5120320; Fri, 6 Nov 2020 11:47:59 -0500 (EST) In-Reply-To: (Mauro Aranda's message of "Fri, 6 Nov 2020 12:30:41 -0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 08:56:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258832 Archived-At: > I made a dumb mistake while fixing Bug#34027. When enabling a theme we > need to change the theme-value or theme-face property of the symbols > the theme customizes, and also save a "changed" value, in case there is > any. Since custom-push-theme did that, I thought it was fine to call > custom-push-theme here and in disable-theme (I haven't had the time yet > to test if something bad happens in disable-theme). > > As a result, theme settings, saved under the theme-settings property of > THEME, got duplicated (you can see the code that adds each setting, at > the end of custom-push-theme). So, this change fixes that bug I > introduced. I see, thanks. > Since the test for Bug#34027, custom--test-theme-variables, still pass > after the change, I didn't consider adding a test for this. But sure, > it should be easy to add one. That would be very appreciated. Stefan