From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [feature/native-comp] breakage on build Date: Mon, 01 Feb 2021 14:37:27 -0500 Message-ID: References: <87lfca7lsb.fsf@russet.org.uk> <463a837ca8ddbf7533c403350d75125d@russet.org.uk> <39105f71034e0902a749994dda9c4704@russet.org.uk> <83mtwq8kf3.fsf@gnu.org> <83k0ru8jnx.fsf@gnu.org> <83im7e8icf.fsf@gnu.org> <838s8a8adr.fsf@gnu.org> <83sg6h6s6d.fsf@gnu.org> <8335yf7qtf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36492"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , phillip.lord@russet.org.uk, Andrea Corallo To: akrl--- via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 01 20:39:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6f2k-0009MR-Px for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Feb 2021 20:39:26 +0100 Original-Received: from localhost ([::1]:56372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6f2j-0004XU-R1 for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Feb 2021 14:39:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6f0y-0002q8-Ky for emacs-devel@gnu.org; Mon, 01 Feb 2021 14:37:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6f0v-0005QH-0B; Mon, 01 Feb 2021 14:37:35 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1DA3E80722; Mon, 1 Feb 2021 14:37:29 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BDD4A80C19; Mon, 1 Feb 2021 14:37:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612208247; bh=Sq3Ao3/tKDpX+d5cJj0sMRNrTLHEapQdPDjKXHf+Utw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lhptQ4oxkr1irbB3K1AZWVP0P4vFUADeJXgc3qTua04AZM8B4WrS44ET6gug3Nwt2 bNVBRSK/QlK/h5Wk6gkuO/NBmJ3uhaRFFXAMYsrLC/3YkMhD+QKupdLNwV468F1haw oMMYzTEvB8yTiZ1UaLepJFV3HMGEgjrmtBlvbda0dvMnRfqUNu/BJPT09S5EoGag37 08XWKA3zAjca1rMtwpTOrcg6cB2LFpDN8eO4Af7zxuNTSNwcw/3Ze1QQIfEDFUV6M2 zkkJRxsgFPQgyF3CMMdTxRKYQziV35ufFoHydeBQUA7PptJkK9nKBn7YH7pgXiZ8p8 WXNEhcTIcEI5Q== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B069A1203FF; Mon, 1 Feb 2021 14:37:27 -0500 (EST) In-Reply-To: (akrl's message of "Mon, 01 Feb 2021 16:20:17 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263695 Archived-At: > I think with eln the situation is considerably more sentitive than the > elc one in this respect. The reason is that we (on purpose) skip > Ffuncall to call directly into C code, as a consequence an > incompatibility will most certainly lead to a crash and not > a runtime error. Indeed, it's more like the `pdmp` fingerprint check. > 1- We merge HASH1 and HASH3 > > - In this case everything will work as of now but certain operations > will become more difficult, the typical example is manually removing > all the eln left by an old Emacs configuration that is not anymore > in use (me and others do this quite often). Can we erase those files based on their `mtime` instead (maybe comparing their `mtime` to that of the `emacs` executable)? > 2- We move HASH1 into the eln as metadata. > > - The limitation of 1 persists > > - To check that each eln is loadable one has: to 'dlopen' it, read the > metadata ('dlsym'), verify and in case reject. This is certainly > way more expansive than directly searching for a given filename and > might impact negatively startup time, especially on certain OSes > where opening files is an expensive operation. > > - We'd have name clashes for different eln coming from different > Emacs configurations/versions. We can combine that with a shorter hash in the file-name. The short hash in the file name will eliminate the vast majority of name clashes. Stefan