From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Introducing face in comments for various modes Date: Mon, 12 Dec 2022 10:20:23 -0500 Message-ID: References: <9ZK1Solghrmps4AarUsz2E6-mAdkrTZoXPs4RTRTd9sZ0Cd8DGhK955im1kuug-EZXU3tc5rgDDd16vQexxpFnMvMFjFqnNnh0noashyLdE=@protonmail.com> <0RJB0bPRTMAqXlUbL2kGUvJtnCNPYwPhqTNi_l9nIpQAciTZYcYCikFVqi2Nr_UZLbT1_DRtX8G0dSkgI4jln5DTYBDxLz4i7L2d9wx-kA8=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Heime , help-gnu-emacs@gnu.org To: Thibaut Verron Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 16:21:35 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4kcZ-0000yR-CX for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 16:21:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4kbd-0007RU-HW; Mon, 12 Dec 2022 10:20:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4kbY-0007OF-Em for help-gnu-emacs@gnu.org; Mon, 12 Dec 2022 10:20:35 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4kbW-0006jz-84 for help-gnu-emacs@gnu.org; Mon, 12 Dec 2022 10:20:31 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 78CD780776; Mon, 12 Dec 2022 10:20:26 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EC4C3804C0; Mon, 12 Dec 2022 10:20:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670858425; bh=2bcM2aSg8EwEIF9RfuRVxjU9gvE9hQQl49+oIWR5Kyk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HDypL4AATfaJGGnzMvfL3mpOfeDy0JtRUOcAcYmMHQEj6SPI1Pb5uzC/UYVL93sq7 9xsGE/Kj7gPczqwVrZojyL2vwZaGmVSYsK2KjxUsPkLLTm8olOts2Fd+BDZ3HWXeJk LI3QbKxdv3NJMXBE+Yeza0R2FdcEvGAgYJn5qsAglCTtK1ZhT0lPA7miQZjyGFtNUp b4cocognlhL3mNHgooLHvKqypmld4hBav8HQq2ThpsWa5okJ395jF4NzdRu1kzpi4v 0KVdgDBcQvyg1ibjndCf/ZgrcjqhCC47nQVa2+3yxqY1z2lHbQ9ZhBSigpkPIOcJqj 4JbAb678J+qdg== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8B9B41209C1; Mon, 12 Dec 2022 10:20:24 -0500 (EST) In-Reply-To: (Thibaut Verron's message of "Mon, 12 Dec 2022 09:49:41 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:141675 Archived-At: > The colors of the standard themes are chosen with its (light) background in > mind. If you change that background, it is not surprising that things fall > apart. Many of the basic faces come with definitions that explicitly account for both light and dark backgrounds (e.g. changing color depending on the case). So if a face has poor legibility on a dark background, please report it as a bug. That bug won't necessarily be fixed, because there might be other concerns (we're talking about the defaults, so this has to satisfy many conflicting requirements :-( ), but it's still the right thing to do. > At any rate, Stefan's suggestion would not require making new design > choices, as there are already faces designed for fontifying headers: > outline-1, outline-2, etc. And personally, I probably wouldn't use colors for those faces. Instead I'd probably go with a proportional font with a size that varies depending on the level. Stefan